From 7a5426753676c534c304b94597edc8ca2ed286fe Mon Sep 17 00:00:00 2001 From: Nico Rehwaldt Date: Thu, 30 Apr 2015 10:52:34 +0200 Subject: [PATCH] fix(replace): remove unused modeling dependency The modeling module should be provided by components explicitly. This allows users to replace it for customization. --- lib/features/replace/index.js | 3 +-- test/spec/features/context-pad/ContextPadProviderSpec.js | 5 +++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/features/replace/index.js b/lib/features/replace/index.js index 39dc3f36..8f7ed6ca 100644 --- a/lib/features/replace/index.js +++ b/lib/features/replace/index.js @@ -2,8 +2,7 @@ module.exports = { __depends__: [ require('diagram-js/lib/features/popup-menu'), require('diagram-js/lib/features/replace'), - require('diagram-js/lib/features/selection'), - require('../modeling') + require('diagram-js/lib/features/selection') ], bpmnReplace: [ 'type', require('./BpmnReplace') ] }; \ No newline at end of file diff --git a/test/spec/features/context-pad/ContextPadProviderSpec.js b/test/spec/features/context-pad/ContextPadProviderSpec.js index d2220672..6ede5dc9 100644 --- a/test/spec/features/context-pad/ContextPadProviderSpec.js +++ b/test/spec/features/context-pad/ContextPadProviderSpec.js @@ -6,7 +6,8 @@ var TestHelper = require('../../../TestHelper'); var contextPadModule = require('../../../../lib/features/context-pad'), - bpmnModule = require('../../../../lib/core'), + coreModule = require('../../../../lib/core'), + modelingModule = require('../../../../lib/features/modeling'), popupModule = require('diagram-js/lib/features/popup-menu'), replaceModule = require('diagram-js/lib/features/replace'); @@ -15,7 +16,7 @@ describe('features - context-pad', function() { var diagramXML = require('../../../fixtures/bpmn/simple.bpmn'); - var testModules = [ contextPadModule, bpmnModule, popupModule, replaceModule ]; + var testModules = [ contextPadModule, coreModule, modelingModule, popupModule, replaceModule ]; beforeEach(bootstrapViewer(diagramXML, { modules: testModules }));