sartography
/
bpmn-js
mirror of https://github.com/sartography/bpmn-js.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(modeling): adjust default size for participants 

From 600x300 -> 600x250.

Closes #262
This commit is contained in:
Nico Rehwaldt 2015-05-05 13:29:28 +02:00
parent e912e1f89c
commit 4f236382a0
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/features/modeling/ElementFactory.js
View File

@ -117,7 +117,7 @@ ElementFactory.prototype._getDefaultSize = function(semantic) {
}
if (semantic.$instanceOf('bpmn:Participant')) {
return { width: 600, height: 300 };
return { width: 600, height: 250 };
}
return { width: 100, height: 80 };

16
test/spec/features/snapping/BpmnSnappingSpec.js
View File

@ -59,7 +59,7 @@ describe('features/snapping - BpmnSnapping', function() {
// then
expect(bounds(participantShape)).toEqual({
width: 600, height: 300, x: 18, y: -58
width: 600, height: 250, x: 18, y: -8
});
}));
@ -82,7 +82,7 @@ describe('features/snapping - BpmnSnapping', function() {
// then
expect(bounds(participantShape)).toEqual({
width: 600, height: 300, x: 100, y: 52
width: 600, height: 250, x: 100, y: 52
});
}));
@ -121,7 +121,7 @@ describe('features/snapping - BpmnSnapping', function() {
// then
expect(bounds(participantShape)).toEqual({
width: 600, height: 300, x: 100, y: 250
x: 100, y: 275, width: 600, height: 250
});
}));
@ -160,16 +160,16 @@ describe('features/snapping - BpmnSnapping', function() {
// then
expect(bounds(participantShape)).toEqual({
width: 600, height: 300, x: 100, y: 250
x: 100, y: 275, width: 600, height: 250
});
}));
});
describe('on shape resize', function () {
var diagramXML = require('../../../fixtures/bpmn/collaboration-resize.bpmn');
var testResizeModules = [ coreModule, resizeModule, rulesModule, snappingModule ];
beforeEach(bootstrapModeler(diagramXML, { modules: testResizeModules }));
@ -182,7 +182,7 @@ describe('features/snapping - BpmnSnapping', function() {
it('should snap a SubProcess to minimum bounds', inject(function(canvas, elementRegistry, resize, dragging) {
var subProcess = elementRegistry.get('SubProcess_1');
resize.activate(Events.create(canvas._svg, { x: 453, y: 624 }), subProcess, 'se');
@ -207,7 +207,7 @@ describe('features/snapping - BpmnSnapping', function() {
}));
it('should snap a TextAnnotation to minimum bounds', inject(function(canvas, elementRegistry, resize, dragging) {
var textAnnotation = elementRegistry.get('TextAnnotation_1');
resize.activate(Events.create(canvas._svg, { x: 592, y: 452 }), textAnnotation, 'se');