From 1d46d915d1245d2d53d836e8e824f69372694339 Mon Sep 17 00:00:00 2001 From: Nico Rehwaldt Date: Mon, 17 Mar 2014 11:11:25 +0100 Subject: [PATCH] fix(BpmnTreeWalker): do not fail if no di --- lib/BpmnTreeWalker.js | 11 +++++++++-- test/spec/browser/ImporterSpec.js | 11 +++++++++++ 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/lib/BpmnTreeWalker.js b/lib/BpmnTreeWalker.js index dcd1bbcf..4d635837 100644 --- a/lib/BpmnTreeWalker.js +++ b/lib/BpmnTreeWalker.js @@ -14,7 +14,7 @@ function BpmnTraverser(visitor) { } function is(element, type) { - return element.__isInstanceOf(type); + return element.__instanceOf(type); } function visit(element, di, ctx) { @@ -82,7 +82,14 @@ function BpmnTraverser(visitor) { } if (!diagram) { - diagram = diagrams[0]; + if (diagrams && diagrams.length) { + diagram = diagrams[0]; + } + } + + // no diagram -> nothing to import + if (!diagram) { + return; } var rootElement = diagram.plane.bpmnElement; diff --git a/test/spec/browser/ImporterSpec.js b/test/spec/browser/ImporterSpec.js index b33a40dd..c7b82496 100644 --- a/test/spec/browser/ImporterSpec.js +++ b/test/spec/browser/ImporterSpec.js @@ -36,4 +36,15 @@ describe('Importer', function() { diagram.importDefinitions(result, done); }); }); + + it('should import empty definitions', function(done) { + + var xml = fs.readFileSync('test/fixtures/bpmn/empty-definitions.bpmn', 'utf8'); + + read(xml, function(err, result) { + var diagram = new Diagram(container); + + diagram.importDefinitions(result, done); + }); + }); }); \ No newline at end of file