From 13a9d24e844650966564216eef6a5259febb3193 Mon Sep 17 00:00:00 2001 From: hoferch91 Date: Tue, 16 Aug 2016 15:42:46 +0200 Subject: [PATCH] fix(replace-menu): a compensation handler can also be a call-activity closes #603 --- lib/features/popup-menu/ReplaceMenuProvider.js | 8 -------- test/spec/features/popup-menu/ReplaceMenuProviderSpec.js | 4 ++-- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/lib/features/popup-menu/ReplaceMenuProvider.js b/lib/features/popup-menu/ReplaceMenuProvider.js index c909dcf4..7fdc2d12 100644 --- a/lib/features/popup-menu/ReplaceMenuProvider.js +++ b/lib/features/popup-menu/ReplaceMenuProvider.js @@ -203,14 +203,6 @@ ReplaceMenuProvider.prototype.getEntries = function(element) { if (is(businessObject, 'bpmn:FlowNode')) { entries = filter(replaceOptions.TASK, differentType); - if (businessObject.isForCompensation) { - - // can only replace to compensation activities - entries = filter(entries, function(entry) { - return !/CallActivity/.test(entry.target.type); - }); - } - // collapsed SubProcess can not be replaced with itself if (is(businessObject, 'bpmn:SubProcess') && !isExpanded(businessObject)) { entries = reject(entries, function(entry) { diff --git a/test/spec/features/popup-menu/ReplaceMenuProviderSpec.js b/test/spec/features/popup-menu/ReplaceMenuProviderSpec.js index 3b8c1ce5..55a15fed 100644 --- a/test/spec/features/popup-menu/ReplaceMenuProviderSpec.js +++ b/test/spec/features/popup-menu/ReplaceMenuProviderSpec.js @@ -1068,7 +1068,7 @@ describe('features/popup-menu - replace menu provider', function() { beforeEach(bootstrapModeler(diagramXML, { modules: testModules })); - it('should exclude non-activities from options', inject(function(elementRegistry, popupMenu) { + it('options should include subProcesses and callActivity', inject(function(elementRegistry, popupMenu) { // given var taskElement = elementRegistry.get('Task_1'); @@ -1080,7 +1080,7 @@ describe('features/popup-menu - replace menu provider', function() { subProcessEntry = queryEntry(popupMenu, 'replace-with-collapsed-subprocess'); // then - expect(callActivityEntry).to.not.exist; + expect(callActivityEntry).to.exist; expect(subProcessEntry).to.exist; }));