From 0f621834109b2f64c500b022a7c45e0ef7b5dda0 Mon Sep 17 00:00:00 2001
From: Nico Rehwaldt <nico.rehwaldt@camunda.com>
Date: Wed, 16 May 2018 13:12:18 +0200
Subject: [PATCH] test(modeling): verify missing bpmndi:BPMNLabel update
 behavior

---
 ...nds.bpmn => BpmnUpdater.incompleteDi.bpmn} |  8 ++++--
 .../spec/features/modeling/BpmnUpdaterSpec.js | 27 ++++++++++++++++---
 2 files changed, 30 insertions(+), 5 deletions(-)
 rename test/spec/features/modeling/{BpmnUpdater.missingBounds.bpmn => BpmnUpdater.incompleteDi.bpmn} (71%)

diff --git a/test/spec/features/modeling/BpmnUpdater.missingBounds.bpmn b/test/spec/features/modeling/BpmnUpdater.incompleteDi.bpmn
similarity index 71%
rename from test/spec/features/modeling/BpmnUpdater.missingBounds.bpmn
rename to test/spec/features/modeling/BpmnUpdater.incompleteDi.bpmn
index 29963b82..f8bb7a2b 100644
--- a/test/spec/features/modeling/BpmnUpdater.missingBounds.bpmn
+++ b/test/spec/features/modeling/BpmnUpdater.incompleteDi.bpmn
@@ -2,13 +2,17 @@
 <semantic:definitions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:semantic="http://www.omg.org/spec/BPMN/20100524/MODEL" id="Definitions" targetNamespace="http://bpmn.io/schema/bpmn">
   <semantic:process id="Process">
     <semantic:startEvent id="StartEvent" />
+    <semantic:startEvent id="StartEvent_2" name="Start" />
   </semantic:process>
-  <bpmndi:BPMNDiagram id="Trisotech.Visio-_6" name="Untitled Diagram" documentation="" resolution="96.00000267028808">
+  <bpmndi:BPMNDiagram id="BPMNDiagram_1">
     <bpmndi:BPMNPlane bpmnElement="Process">
       <bpmndi:BPMNShape id="StartEvent_di" bpmnElement="StartEvent">
         <dc:Bounds x="192" y="123" width="36" height="36" />
         <bpmndi:BPMNLabel />
       </bpmndi:BPMNShape>
+      <bpmndi:BPMNShape id="StartEvent_2_di" bpmnElement="StartEvent_2">
+        <dc:Bounds x="306" y="123" width="36" height="36" />
+      </bpmndi:BPMNShape>
     </bpmndi:BPMNPlane>
   </bpmndi:BPMNDiagram>
-</semantic:definitions>
\ No newline at end of file
+</semantic:definitions>
diff --git a/test/spec/features/modeling/BpmnUpdaterSpec.js b/test/spec/features/modeling/BpmnUpdaterSpec.js
index 013f8200..ecdc4eef 100644
--- a/test/spec/features/modeling/BpmnUpdaterSpec.js
+++ b/test/spec/features/modeling/BpmnUpdaterSpec.js
@@ -89,16 +89,16 @@ describe('features - bpmn-updater', function() {
   });
 
 
-  describe('missing bpmndi:Bounds', function() {
+  describe('incomplete DI', function() {
 
-    var diagramXML = require('./BpmnUpdater.missingBounds.bpmn');
+    var diagramXML = require('./BpmnUpdater.incompleteDi.bpmn');
 
     beforeEach(bootstrapModeler(diagramXML, {
       modules: testModules
     }));
 
 
-    it('should add bpmndi:Bounds', inject(
+    it('should add missing label bpmndi:Bounds', inject(
       function(modeling, elementRegistry) {
 
         // given
@@ -121,6 +121,27 @@ describe('features - bpmn-updater', function() {
       }
     ));
 
+
+    it('should add missing bpmndi:BPMNLabel', inject(
+      function(modeling, elementRegistry) {
+
+        // given
+        var event = elementRegistry.get('StartEvent_2'),
+            label = event.label,
+            di = event.businessObject.di;
+
+        // when
+        modeling.moveElements([ label ], { x: 20, y: 20 });
+
+        var diLabel = di.label;
+
+        // then
+        expect(diLabel).to.exist;
+
+        expect(diLabel.bounds).to.exist;
+      }
+    ));
+
   });
 
 });