sartography
/
bpmn-js
mirror of https://github.com/sartography/bpmn-js.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

feat(modeling): lay out connection once per event attachment

This commit is contained in:
Nico Rehwaldt 2019-06-04 12:07:55 +02:00 committed by merge-me[bot]
parent d14e3735a4
commit 0a6cecc609
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/features/modeling/behavior/AttachEventBehavior.js
View File

@ -45,7 +45,7 @@ export default function AttachEventBehavior(eventBus, bpmnReplace) {
boundaryEvent.eventDefinitionType = eventDefinition.$type;
}
newShape = bpmnReplace.replaceElement(shape, boundaryEvent);
newShape = bpmnReplace.replaceElement(shape, boundaryEvent, { layoutConnection: false });
context.shapes = [ newShape ];
}

23
test/spec/features/modeling/behavior/AttachEventBehaviorSpec.js
View File

@ -1,3 +1,5 @@
/* global sinon */
import {
bootstrapModeler,
inject
@ -102,6 +104,7 @@ describe('features/modeling/behavior - attach events', function() {
it('should remove incoming connection', inject(function(elementRegistry, modeling) {
// given
var event = elementRegistry.get(eventId),
subProcess = elementRegistry.get('SubProcess_1'),
gateway = elementRegistry.get('Gateway_1'),
@ -122,6 +125,7 @@ describe('features/modeling/behavior - attach events', function() {
it('should keep outgoing connection', inject(function(elementRegistry, modeling) {
// given
var event = elementRegistry.get(eventId),
subProcess = elementRegistry.get('SubProcess_1'),
task = elementRegistry.get('Task_1'),
@ -138,6 +142,25 @@ describe('features/modeling/behavior - attach events', function() {
expect(boundaryEvent.outgoing).to.have.lengthOf(1);
expect(task.incoming).to.have.lengthOf(1);
}));
it('should lay out connection once', inject(function(eventBus, elementRegistry, modeling) {
// given
var layoutSpy = sinon.spy(),
event = elementRegistry.get(eventId),
subProcess = elementRegistry.get('SubProcess_1');
eventBus.on('commandStack.connection.layout.execute', layoutSpy);
var elements = [ event ];
// when
modeling.moveElements(elements, { x: 0, y: -90 }, subProcess, { attach: true });
// then
expect(layoutSpy).to.be.calledOnce;
}));
});
});