Merge pull request #39 from sartography/message_fixes

Message fixes

.github/workflows/tests.yml

@@ -20,7 +20,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3 #Checkout Repo
       - uses: actions/setup-node@v3 #Setup Node
-      - uses: nanasess/setup-chromedriver@v1
+      - uses: nanasess/setup-chromedriver@v2 #Setup ChromeDriver
         with:
           node-version: '18'
       - name: Run Karma Tests

app/spiffworkflow/messages/MessageHelpers.js

@@ -148,14 +148,24 @@ function getRetrievalExpressionFromCorrelationProperty(
 export function findCorrelationProperties(businessObject, moddle) {
   const root = getRoot(businessObject, moddle);
   const correlationProperties = [];
-  for (const rootElement of root.rootElements) {
-    if (rootElement.$type === 'bpmn:CorrelationProperty') {
-      correlationProperties.push(rootElement);
+  if (isIterable(root.rootElements)) {
+    for (const rootElement of root.rootElements) {
+      if (rootElement.$type === 'bpmn:CorrelationProperty') {
+        correlationProperties.push(rootElement);
+      }
     }
   }
   return correlationProperties;
 }
 
+function isIterable(obj) {
+  // checks for null and undefined
+  if (obj == null) {
+    return false;
+  }
+  return typeof obj[Symbol.iterator] === 'function';
+}
+
 export function findCorrelationKeys(businessObject, moddle) {
   const root = getRoot(businessObject, moddle);
   const correlationKeys = [];

app/spiffworkflow/messages/propertiesPanel/MessageSelect.js

@@ -35,6 +35,9 @@ export function MessageSelect(props) {
           commandStack.execute('element.updateModdleProperties', {
             element: shapeElement,
             moddleElement: businessObject,
+            properties: {
+              messageRef: message,
+            },
           });
         } else if (
           businessObject.$type === 'bpmn:ReceiveTask' ||