sartography
/
bpmn-js-spiffworkflow
mirror of https://github.com/sartography/bpmn-js-spiffworkflow.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Handle Broken Tests 3

This commit is contained in:
theaubmov 2023-12-02 18:05:31 +01:00
parent d3a1f38258
commit 80dcc92d2f
3 changed files with 24 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/spiffworkflow/DataObject/propertiesPanel/DataObjectSelect.js
View File

@ -46,7 +46,6 @@ export function DataObjectSelect(props) {
// Construct the new name by : the dataObject name and the current state
const stateName = businessObject.dataState && businessObject.dataState.name ? businessObject.dataState.name : '';
const newName = stateName ? `${dataObject.name} [${stateName}]` : dataObject.name;
// Update the name property of the DataObjectReference
commandStack.execute('element.updateProperties', {
element: element,

38
test/spec/DataObjectPropsSpec.js
View File

@ -1,9 +1,17 @@
import {
bootstrapPropertiesPanel, changeInput,
bootstrapPropertiesPanel,
changeInput,
expectSelected,
findEntry, findInput, findSelect,
findEntry,
findInput,
findSelect
} from './helpers';
import { BpmnPropertiesPanelModule, BpmnPropertiesProviderModule } from 'bpmn-js-properties-panel';
import {
BpmnPropertiesPanelModule,
BpmnPropertiesProviderModule
} from 'bpmn-js-properties-panel';
import spiffModdleExtension from '../../app/spiffworkflow/moddle/spiffworkflow.json';
import TestContainer from 'mocha-test-container-support';
import DataObject from '../../app/spiffworkflow/DataObject';
@ -103,20 +111,20 @@ describe('Properties Panel for Data Objects', function() {
expect(my_data_ref_1.businessObject.name).not.to.equal('My Nifty New Name');
});
// it('selecting a different data object should not change the data object reference name.', async function() {
it('selecting a different data object should not change the data object reference name.', async function() {
// // IF - a data object reference is selected
// let my_data_ref_1 = await expectSelected('my_data_ref_1');
// IF - a data object reference is selected
let my_data_ref_1 = await expectSelected('my_data_ref_1');
// let entry = findEntry('selectDataObject', container);
// let selector = findSelect(entry);
// let businessObject = my_data_ref_1.businessObject;
// changeInput(selector, 'my_third_data_object');
let entry = findEntry('selectDataObject', container);
let selector = findSelect(entry);
let businessObject = my_data_ref_1.businessObject;
// expect(businessObject.get('dataObjectRef').id).to.equal('my_third_data_object');
// expect(businessObject.name).to.equal('my_data_object');
// expect(businessObject.name).not.to.equal('My Third Data Object');
// });
changeInput(selector, 'my_third_data_object');
expect(businessObject.get('dataObjectRef').id).to.equal('my_third_data_object');
expect(businessObject.name).to.equal('D3');
expect(businessObject.name).not.to.equal('my_data_object');
});
});

2
test/spec/bpmn/diagram.bpmn
View File

@ -38,7 +38,7 @@
<bpmn:script>elizabeth="awesome"</bpmn:script>
</bpmn:scriptTask>
<bpmn:dataObject id="my_other_data_object" />
<bpmn:dataObject id="my_third_data_object" />
<bpmn:dataObject id="my_third_data_object" name="D3" />
<bpmn:dataObjectReference id="my_data_ref_1" name="my_data_object" dataObjectRef="my_data_object" />
<bpmn:sequenceFlow id="Flow_132laxn" sourceRef="task_confirm" targetRef="business_rule_task" />
<bpmn:userTask id="task_confirm" name="confirm contentment">