From fbbe47bcc96e248e5fe917a7023173c7435b55db Mon Sep 17 00:00:00 2001
From: M Alghazwi <m.ghazwi@gmail.com>
Date: Tue, 11 Feb 2025 13:54:21 +0100
Subject: [PATCH] comment out unsafe state permutation

---
 benches/iterated_perm.rs      | 2 +-
 src/hash.rs                   | 6 +++---
 src/skyscraper/permutation.rs | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/benches/iterated_perm.rs b/benches/iterated_perm.rs
index 210dd69..baa8e66 100644
--- a/benches/iterated_perm.rs
+++ b/benches/iterated_perm.rs
@@ -24,7 +24,7 @@ fn bench_iterated_perm(c: &mut Criterion , h: Hash, n: usize) {
 fn bench_permutations(c: &mut Criterion) {
   bench_iterated_perm(c, Hash::Poseidon2, 10000);
   bench_iterated_perm(c, Hash::Griffin  , 10000);
-  bench_iterated_perm(c, Hash::Skyscraper  , 10000);
+  // bench_iterated_perm(c, Hash::Skyscraper  , 10000);
 }
 
 //------------------------------------------------------------------------------
diff --git a/src/hash.rs b/src/hash.rs
index de72bb0..27d5d23 100644
--- a/src/hash.rs
+++ b/src/hash.rs
@@ -12,7 +12,7 @@ use crate::griffin;
 pub enum Hash {
   Poseidon2,
   Griffin,
-  Skyscraper
+  // Skyscraper
 }
 
 //------------------------------------------------------------------------------
@@ -21,7 +21,7 @@ pub fn permute(h: Hash, s: State) -> State {
   match h {
     Hash::Poseidon2 => poseidon2::permutation::permute(s),
     Hash::Griffin   =>   griffin::permutation::permute(s),
-    Hash::Skyscraper   =>   skyscraper::permutation::permute_state(s),
+    // Hash::Skyscraper   =>   skyscraper::permutation::permute_state(s),
   }
 }
 
@@ -29,7 +29,7 @@ pub fn permute_inplace(h: Hash, s: &mut State){
   match h {
     Hash::Poseidon2 => poseidon2::permutation::permute_inplace(s),
     Hash::Griffin   =>   griffin::permutation::permute_inplace(s),
-    Hash::Skyscraper   =>   skyscraper::permutation::permute_state_inplace(s),
+    // Hash::Skyscraper   =>   skyscraper::permutation::permute_state_inplace(s),
   };
 }
 
diff --git a/src/skyscraper/permutation.rs b/src/skyscraper/permutation.rs
index a7dd194..e9586f4 100644
--- a/src/skyscraper/permutation.rs
+++ b/src/skyscraper/permutation.rs
@@ -122,7 +122,7 @@ pub fn permute(input: [F; 2]) -> [F; 2] {
 
 /// WARNING: this ignores the z element of the state
 /// TODO: extension field
-pub fn permute_state_inplace(u: &mut State) {
+pub(crate) fn permute_state_inplace(u: &mut State) {
     let ns = permute([u.x,u.y]);
     u.x = ns[0];
     u.y = ns[1];
@@ -130,7 +130,7 @@ pub fn permute_state_inplace(u: &mut State) {
 
 /// WARNING: this ignores the z element of the state
 /// TODO: extension field
-pub fn permute_state(mut u: State) -> State{
+pub(crate) fn permute_state(mut u: State) -> State{
     permute_state_inplace(&mut u);
     u
 }