54 Commits

Author SHA1 Message Date
wborgeaud
b228cc72fe s/columns/registers 2022-06-28 02:28:25 +02:00
Daniel Lubarov
34e73db42b
Memory naming tweaks (#579)
* Memory naming tweaks

- Define the channel count and value limbs in a single place, so they're easy to adjust.
- Standardize on "channels" which I think is more explicit, since e.g. `num_mem_ops` used to mean either the channel count or total operation count in a trace.

* feedback

* tweaks

* fmt
2022-06-27 16:03:56 -07:00
Daniel Lubarov
3346d3f902
field_types -> types (#583)
* `field_types` -> `types`

Here too, I think "field" is usually clear from context, e.g. in `use plonky2::field::types::Field;`.

* fixes

* fmt
2022-06-27 12:24:09 -07:00
Daniel Lubarov
475964a6bb
Move CTL config out of test (#578)
* Move CTL config out of test

Since the same config will be used in other tests (and maybe external callers, unless we add an API later to abstract it).

* fmt

* Split up CTLs
2022-06-27 10:40:16 -07:00
Daniel Lubarov
410e03349c
extension_field -> extension (#581)
It seems redundant in most contexts, e.g. `use plonky2::field::extension_field::Extendable;`. One could import `extension_field`, but it's not that common in Rust, and `field::extension` is now about as short.
2022-06-27 07:18:21 -07:00
Jacqueline Nabaglo
912281de9b
CTL: limbs (CPU) <-> bits (logic) (#577)
* CTL: limbs (CPU) <-> bits (logic)

* Minor: stray TODO mark

* Document Zero op

* Util for constructing an int from bits
2022-06-25 13:34:04 -07:00
Nicholas Ward
4a7ebf057b updated in line with main changes 2022-06-23 14:36:14 -07:00
Nicholas Ward
791b15f94f cleanup 2022-06-23 14:01:22 -07:00
Nicholas Ward
4d69998cde fix and cleanup 2022-06-23 14:01:22 -07:00
Nicholas Ward
d911eecd37 fixes 2022-06-23 14:01:22 -07:00
Nicholas Ward
29fa32465c fixes 2022-06-23 14:01:22 -07:00
Nicholas Ward
d6983951a4 attempted fix 2022-06-23 14:01:22 -07:00
Nicholas Ward
f16db8c564 fmt 2022-06-23 14:01:22 -07:00
Nicholas Ward
593d3eeffd fixes 2022-06-23 14:01:22 -07:00
Nicholas Ward
9434819829 addressed comments 2022-06-23 14:01:22 -07:00
Nicholas Ward
2d7f2b47c2 fmt 2022-06-23 14:01:22 -07:00
Nicholas Ward
a2c14077d2 fixes 2022-06-23 14:01:22 -07:00
Nicholas Ward
08be9811cd timestamp fixes 2022-06-23 14:01:18 -07:00
Nicholas Ward
5707732b75 fix 2022-06-23 14:00:48 -07:00
Nicholas Ward
bf58c20329 updates to registers, new cross-table lookups 2022-06-23 14:00:48 -07:00
Nicholas Ward
59f3a763f0 transition constraints, and debugging 2022-06-23 14:00:01 -07:00
Nicholas Ward
03112f898a updated all_stark framework to include memory stark (doesn't pass yet) 2022-06-23 13:59:57 -07:00
Nicholas Ward
fcf216012c memory row generation 2022-06-23 13:59:06 -07:00
Jacqueline Nabaglo
3aaab765dd
define columns for CTL closer to the constraints (#573) 2022-06-21 10:28:44 -07:00
Jacqueline Nabaglo
1cc000d3e1
Connect logic stark to CPU (#569)
* WIP: connect logic stark to CPU

* Tests passing
2022-06-17 11:57:14 -07:00
wborgeaud
0d8461d66d PR feedback 2022-06-15 17:01:30 +02:00
wborgeaud
6a13ecf164 Remove enum and use Option for filter 2022-06-14 19:09:03 +02:00
wborgeaud
1dce18495a Remove Keccak input limbs 2022-06-14 01:21:17 +02:00
wborgeaud
d626679c6c Column enum 2022-06-14 00:53:31 +02:00
wborgeaud
e969f10b20 PR feedback 2022-06-13 18:54:12 +02:00
wborgeaud
fdd6a7cad8 Wired CPU and Keccak 2022-06-10 21:02:56 +02:00
wborgeaud
039d4efa10 Merge branch 'main' into filtered_ctl
# Conflicts:
#	evm/src/all_stark.rs
2022-06-10 20:11:00 +02:00
wborgeaud
8bd6bebdc7 INPUT_LIMBS -> NUM_INPUTS 2022-06-10 19:30:51 +02:00
wborgeaud
30abe19e42 Fix 2022-06-10 00:49:22 +02:00
wborgeaud
aa8d69d27a Minor 2022-06-09 23:42:17 +02:00
wborgeaud
51f66d4dac Fix constraint 2022-06-09 23:36:43 +02:00
wborgeaud
4e848c77db Merge conflicts 2022-06-09 18:13:41 +02:00
Nicholas Ward
85d84a130f moved back haha 2022-06-07 14:20:51 -07:00
Nicholas Ward
9c6e650916 moved allow to local 2022-06-07 14:15:28 -07:00
Nicholas Ward
67167d8e03 use bit operations 2022-06-07 10:57:06 -07:00
Nicholas Ward
c39e927d52 added check on length of 2022-06-07 10:57:06 -07:00
Nicholas Ward
a4300fb6f7 fix 2022-06-07 10:57:06 -07:00
Nicholas Ward
08bda49b70 fmt 2022-06-07 10:57:06 -07:00
Nicholas Ward
82a361f466 trying to fix CTL 2022-06-07 10:57:06 -07:00
Nicholas Ward
e6d0275f2a fmt 2022-06-07 10:57:06 -07:00
Nicholas Ward
2c285ca2cd fixes and debugging 2022-06-07 10:57:06 -07:00
Jacqueline Nabaglo
47efff834f
EVM decode (#553)
* EVM decode

* Style and docs

* Daniel PR comments

* Minor style

* Work on tests

* Tests passing!

* Minor: fix comment

* William comments
2022-06-03 19:24:47 -07:00
wborgeaud
2ecca92bf6 Minor 2022-06-01 20:17:21 +02:00
wborgeaud
2e3a738bc5 Implement multi-table CTLs 2022-06-01 18:53:19 +02:00
wborgeaud
bd738399dd Clippy 2022-05-26 20:44:59 +02:00