23 Commits

Author SHA1 Message Date
Robin Salen
f3f7433c29
Some cleanup (#1498) 2024-02-03 12:21:38 -05:00
Robin Salen
6357963654
Reorganize lookup / ctl modules (#1495)
* Reorganize lookup / ctl modules

* Apply review
2024-02-01 23:19:49 +00:00
Robin Salen
f76245e298
Cleanup imports (#1492) 2024-02-01 07:16:28 -05:00
Linda Guiga
18e08f4f61
Filter range checks (#1433)
* Add filtering to range-checks

* Cleanup

* Fix Clippy

* Apply comment
2023-12-18 17:27:12 -05:00
Hamy Ratoanina
68b9f0ad1c
Add ERC721 test (#1425)
* Add ERC721 test

* Add IS_READ column to BytePacking CTL

* Apply comment
2023-12-15 19:44:59 -05:00
Linda Guiga
5607faf36b
Check that limbs after the length are 0 (#1419)
* Check that limbs after the length are 0

* Update comments

* Update comments
2023-12-08 18:33:10 -05:00
Hamy Ratoanina
46b6aa108d
Implement degree 2 filters (#1404)
* Implement degree 2 filters

* Apply comments
2023-12-05 17:02:37 -05:00
Robin Salen
2d36559dad
Make some functions const (#1407) 2023-12-05 13:41:31 -05:00
Robin Salen
d28ba24059
Pacify clippy (#1403) 2023-12-04 09:51:48 -05:00
Linda Guiga
3440ba94e6
Remove extra rows in BytePackingStark (#1388)
* Have at most one row per (un)packing operation in BytePackingStark

* Change specs

* Fix comment

* Fix tests and apply comments

* Fix log_opcodes
2023-11-28 10:25:03 -05:00
Linda Guiga
48e2b24b49
Add range check constraints for the looked table (#1380)
* Add constraints to check that looked tables are well constructed for range checks

* Fix comments
2023-11-22 15:59:41 -05:00
Robin Salen
01f229a8e1
Add push constraints (#1352)
* Add push constraints

* Fix ranges

* Add stack constraints
2023-11-15 11:15:14 -05:00
Robin Salen
88fcc32983
Reduce visibility for a bunch of structs and methods in EVM crate (#1289)
* Reduce visibility for a bunch of structs and methods

* Remove redundant
2023-11-13 09:26:56 -05:00
shuoer86
a0ea26f4b2
Fix typos in comments 2023-11-04 23:07:36 +08:00
Robin Salen
0d97b93af5
Add some documentation in EVM crate (#1295)
Co-authored-by: Linda Guiga <linda.guiga@toposware.com>
2023-10-30 14:28:24 -04:00
Robin Salen
8afd06cfdd
Fix description of Range-Check columns in STARK modules 2023-09-29 11:24:36 -04:00
Linda Guiga
bbc6fe768f
Merge branch 'main' into 'new-logup' 2023-09-25 11:42:11 -04:00
Robin Salen
d6be2b987b
Remove generic_const_exprs feature from EVM crate (#1246)
* Remove const_generic_exprs feature from EVM crate

* Get a generic impl of StarkFrame
2023-09-22 09:19:13 -04:00
Linda Guiga
f438d45f06
Merge branch 'main' into 'new-logup'. 2023-09-20 12:45:14 -04:00
Robin Salen
6618cfad4a
Remove SEQUENCE_LEN in BytePackingStark (#1241) 2023-09-20 08:31:50 -04:00
Robin Salen
ec9e619678
Fix range 2023-09-15 10:57:32 -04:00
Linda Guiga
17f661f90f
Fix BytePacking range-check. Fix lookup challenges 2023-09-15 09:00:36 +01:00
Robin Salen
9508b49090
Move byte packing / unpacking to a distinct table (#1212)
* Duplicate Memory trace into BytePacking one

* Add mload_32bytes instruction

* Use dedicated ops for byte packing trace

* Change witness generation to reduce memory reads for MLOAD_32BYTES

* Remove segments

* Fix stack

* Fix extra product when fixing CTL for byte_packing

* Write output value in trace

* Add constraints for BYTE_PACKING table

* Add recursive constraints for BYTE_PACKING table

* Fix constraints

* Add address in trace and constraints

* Add timestamp and batch inputs into BytePackingOp struct

* Add extra column

* Fix BytePackingStark CTL

* Tiny fix in witness generation

* Fix the Memory CTL

* Add constraints for the new columns

* Remove 1 column

* Remove limb columns

* Fix

* Fix recursive circuit of BytePackingTable

* Fix constraints

* Fix endianness

* Add MSTORE_32BYTES instruction and move decomposition to packing table

* Add missing constraint

* Add range-check for all bytes

* Add extra constraint

* Cleanup

* Remove REMAINING_LEN column

* Add corresponding implementations in interpreter

* Fix recursive version

* Remove debug assertion because of CI

* Remove FILTER column

* Update new test from rebasing

* Reorder STARK modules to match TraceCheckPoint ordering

* Address comments

* Pacify clippy

* Add documentation to the packing module

* Fix doctest
2023-09-13 04:45:37 +10:00