logos-storage/plonky2
1
0
Fork 0
mirror of https://github.com/logos-storage/plonky2.git synced 2026-01-16 04:33:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Daniel Lubarov <daniel@lubarov.com>
This commit is contained in:
wborgeaud 2021-11-10 09:38:47 +01:00 committed by GitHub
parent 3717ff701e
commit ff943138f3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/util/partial_products.rs
View File

@ -10,12 +10,8 @@ pub fn partial_products<F: Field>(v: &[F], max_degree: usize) -> Vec<F> {
let mut res = Vec::new();
let mut acc = F::ONE;
let chunk_size = max_degree;
let num_chunks = v.len() / chunk_size;
for i in 0..num_chunks {
acc *= v[i * chunk_size..(i + 1) * chunk_size]
.iter()
.copied()
.product();
for chunk in v.chunks_exact(chunk_size) {
acc *= chunk.iter().copied().product();
res.push(acc);
}
@ -40,12 +36,8 @@ pub fn check_partial_products<F: Field>(v: &[F], partials: &[F], max_degree: usi
let mut res = Vec::new();
let mut acc = F::ONE;
let chunk_size = max_degree;
let num_chunks = v.len() / chunk_size;
for i in 0..num_chunks {
acc *= v[i * chunk_size..(i + 1) * chunk_size]
.iter()
.copied()
.product();
for chunk in v.chunks_exact(chunk_size) {
acc *= chunk.iter().copied().product();
let new_acc = *partials.next().unwrap();
res.push(acc - new_acc);
acc = new_acc;
@ -66,13 +58,11 @@ pub fn check_partial_products_recursively<F: RichField + Extendable<D>, const D:
let mut res = Vec::new();
let mut acc = builder.one_extension();
let chunk_size = max_degree;
let num_chunks = v.len() / chunk_size;
for i in 0..num_chunks {
let mut chunk = v[i * chunk_size..(i + 1) * chunk_size].to_vec();
chunk.push(acc);
acc = builder.mul_many_extension(&chunk);
for chunk in v.chunks_exact(chunk_size) {
let chunk_product = builder.mul_many_extension(chunk);
let new_acc = *partials.next().unwrap();
res.push(builder.sub_extension(acc, new_acc));
// Assert that new_acc = acc * chunk_product.
res.push(builder.mul_sub_extension(acc, chunk_product, new_acc));
acc = new_acc;
}
debug_assert!(partials.next().is_none());