From fdd7ee46fe735186b00a7090ead9ff1ae660f14d Mon Sep 17 00:00:00 2001 From: Ayush Shukla Date: Fri, 15 Dec 2023 15:49:34 +0100 Subject: [PATCH] fix: make `from_noncanonical_biguint` work for zero (#1427) --- field/src/goldilocks_field.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/field/src/goldilocks_field.rs b/field/src/goldilocks_field.rs index 94db5b6b..36c6aad2 100644 --- a/field/src/goldilocks_field.rs +++ b/field/src/goldilocks_field.rs @@ -3,7 +3,7 @@ use core::hash::{Hash, Hasher}; use core::iter::{Product, Sum}; use core::ops::{Add, AddAssign, Div, DivAssign, Mul, MulAssign, Neg, Sub, SubAssign}; -use num::{BigUint, Integer}; +use num::{BigUint, Integer, ToPrimitive}; use plonky2_util::{assume, branch_hint}; use serde::{Deserialize, Serialize}; @@ -147,7 +147,7 @@ impl Field for GoldilocksField { } fn from_noncanonical_biguint(n: BigUint) -> Self { - Self(n.mod_floor(&Self::order()).to_u64_digits()[0]) + Self(n.mod_floor(&Self::order()).to_u64().unwrap()) } #[inline(always)]