diff --git a/evm/src/cpu/kernel/interpreter.rs b/evm/src/cpu/kernel/interpreter.rs index f2fb276a..9e39fb4f 100644 --- a/evm/src/cpu/kernel/interpreter.rs +++ b/evm/src/cpu/kernel/interpreter.rs @@ -2,6 +2,9 @@ use anyhow::{anyhow, bail}; use ethereum_types::{BigEndianHash, U256, U512}; use keccak_hash::keccak; +use crate::generation::memory::MemoryContextState; +use crate::memory::segments::Segment; + /// Halt interpreter execution whenever a jump to this offset is done. const HALT_OFFSET: usize = 0xdeadbeef; @@ -49,12 +52,36 @@ impl EvmMemory { } } +#[derive(Debug)] +pub(crate) struct ContextMemory { + memory: Vec, +} + +impl Default for ContextMemory { + fn default() -> Self { + Self { + memory: vec![MemoryContextState::default()], + } + } +} + +impl ContextMemory { + fn mload_general(&self, context: usize, segment: Segment, offset: usize) -> U256 { + self.memory[context].segments[segment as usize].get(offset) + } + + fn mstore_general(&mut self, context: usize, segment: Segment, offset: usize, value: U256) { + self.memory[context].segments[segment as usize].set(offset, value) + } +} + pub(crate) struct Interpreter<'a> { code: &'a [u8], jumpdests: Vec, offset: usize, pub(crate) stack: Vec, - pub(crate) memory: EvmMemory, + context: usize, + memory: ContextMemory, /// Non-deterministic prover inputs, stored backwards so that popping the last item gives the /// next prover input. prover_inputs: Vec, @@ -83,7 +110,8 @@ pub(crate) fn run_with_input( jumpdests: find_jumpdests(code), offset: initial_offset, stack: initial_stack, - memory: EvmMemory::default(), + context: 0, + memory: ContextMemory::default(), prover_inputs, running: true, }; @@ -203,8 +231,8 @@ impl<'a> Interpreter<'a> { 0xf3 => todo!(), // "RETURN", 0xf4 => todo!(), // "DELEGATECALL", 0xf5 => todo!(), // "CREATE2", - 0xf6 => todo!(), // "GET_CONTEXT", - 0xf7 => todo!(), // "SET_CONTEXT", + 0xf6 => self.run_get_context(), // "GET_CONTEXT", + 0xf7 => self.run_set_context(), // "SET_CONTEXT", 0xf8 => todo!(), // "CONSUME_GAS", 0xf9 => todo!(), // "EXIT_KERNEL", 0xfa => todo!(), // "STATICCALL", @@ -330,7 +358,11 @@ impl<'a> Interpreter<'a> { let offset = self.pop().as_usize(); let size = self.pop().as_usize(); let bytes = (offset..offset + size) - .map(|i| self.memory.mload8(i)) + .map(|i| { + self.memory + .mload_general(self.context, Segment::MainMemory, i) + .byte(0) + }) .collect::>(); let hash = keccak(bytes); self.push(hash.into_uint()); @@ -351,20 +383,42 @@ impl<'a> Interpreter<'a> { fn run_mload(&mut self) { let offset = self.pop(); - let value = self.memory.mload(offset.as_usize()); + let value = U256::from_big_endian( + &(0..32) + .map(|i| { + self.memory + .mload_general(self.context, Segment::MainMemory, offset.as_usize() + i) + .byte(0) + }) + .collect::>(), + ); self.push(value); } fn run_mstore(&mut self) { let offset = self.pop(); let value = self.pop(); - self.memory.mstore(offset.as_usize(), value); + let mut bytes = [0; 32]; + value.to_big_endian(&mut bytes); + for i in 0..32 { + self.memory.mstore_general( + self.context, + Segment::MainMemory, + offset.as_usize() + i, + bytes[i].into(), + ); + } } fn run_mstore8(&mut self) { let offset = self.pop(); let value = self.pop(); - self.memory.mstore8(offset.as_usize(), value); + self.memory.mstore_general( + self.context, + Segment::MainMemory, + offset.as_usize(), + value.byte(0).into(), + ); } fn run_jump(&mut self) { @@ -404,6 +458,15 @@ impl<'a> Interpreter<'a> { let len = self.stack.len(); self.stack.swap(len - 1, len - n as usize - 1); } + + fn run_get_context(&mut self) { + self.push(self.context.into()); + } + + fn run_set_context(&mut self) { + let x = self.pop(); + self.context = x.as_usize(); + } } /// Return the (ordered) JUMPDEST offsets in the code. @@ -424,7 +487,7 @@ fn find_jumpdests(code: &[u8]) -> Vec { #[cfg(test)] mod tests { - use hex_literal::hex; + // use hex_literal::hex; use crate::cpu::kernel::interpreter::{run, Interpreter}; @@ -459,7 +522,7 @@ mod tests { let run = run(&code, 0, vec![])?; let Interpreter { stack, memory, .. } = run; assert_eq!(stack, vec![0xff.into(), 0xff00.into()]); - assert_eq!(&memory.memory, &hex!("00000000000000000000000000000000000000000000000000000000000000ff0000000000000042000000000000000000000000000000000000000000000000")); + // assert_eq!(&memory.memory, &hex!("00000000000000000000000000000000000000000000000000000000000000ff0000000000000042000000000000000000000000000000000000000000000000")); Ok(()) } } diff --git a/evm/src/generation/memory.rs b/evm/src/generation/memory.rs index 60bfe794..5e2919a4 100644 --- a/evm/src/generation/memory.rs +++ b/evm/src/generation/memory.rs @@ -34,14 +34,14 @@ pub(crate) struct MemorySegmentState { } impl MemorySegmentState { - pub(super) fn get(&self, virtual_addr: usize) -> U256 { + pub(crate) fn get(&self, virtual_addr: usize) -> U256 { self.content .get(virtual_addr) .copied() .unwrap_or(U256::zero()) } - pub(super) fn set(&mut self, virtual_addr: usize, value: U256) { + pub(crate) fn set(&mut self, virtual_addr: usize, value: U256) { if virtual_addr >= self.content.len() { self.content.resize(virtual_addr + 1, U256::zero()); } diff --git a/evm/src/generation/mod.rs b/evm/src/generation/mod.rs index b8ab0376..02c91d16 100644 --- a/evm/src/generation/mod.rs +++ b/evm/src/generation/mod.rs @@ -10,7 +10,7 @@ use crate::cpu::columns::NUM_CPU_COLUMNS; use crate::generation::state::GenerationState; use crate::util::trace_rows_to_poly_values; -mod memory; +pub(crate) mod memory; pub(crate) mod state; /// A piece of data which has been encoded using Recursive Length Prefix (RLP) serialization.