From d421bd3593973c6cedaff6aa9fcea9ce7281e8e4 Mon Sep 17 00:00:00 2001
From: wborgeaud <williamborgeaud@gmail.com>
Date: Thu, 12 May 2022 22:35:13 +0200
Subject: [PATCH] Lints

---
 starky2/src/all_stark.rs      | 3 ---
 starky2/src/get_challenges.rs | 4 +---
 starky2/src/permutation.rs    | 2 --
 starky2/src/prover.rs         | 3 +--
 starky2/src/verifier.rs       | 1 +
 5 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/starky2/src/all_stark.rs b/starky2/src/all_stark.rs
index 0b5b0316..7542d3bf 100644
--- a/starky2/src/all_stark.rs
+++ b/starky2/src/all_stark.rs
@@ -92,7 +92,6 @@ impl<F: RichField + Extendable<D>, const D: usize> Stark<F, D> for KeccakStark<F
 mod tests {
     use anyhow::Result;
     use plonky2::field::field_types::Field;
-    use plonky2::field::goldilocks_field::GoldilocksField;
     use plonky2::field::polynomial::PolynomialValues;
     use plonky2::plonk::config::{GenericConfig, PoseidonGoldilocksConfig};
     use plonky2::util::timing::TimingTree;
@@ -102,7 +101,6 @@ mod tests {
     use crate::config::StarkConfig;
     use crate::cross_table_lookup::CrossTableLookup;
     use crate::prover::prove;
-    use crate::stark::Stark;
     use crate::verifier::verify_proof;
 
     #[test]
@@ -135,7 +133,6 @@ mod tests {
             .map(F::from_canonical_usize)
             .collect::<Vec<_>>();
         let start = thread_rng().gen_range(0..cpu_stark.num_rows - keccak_stark.num_rows);
-        let start = 0;
 
         cpu_trace[2].values[start..start + keccak_stark.num_rows].copy_from_slice(&vs0);
         cpu_trace[4].values[start..start + keccak_stark.num_rows].copy_from_slice(&vs1);
diff --git a/starky2/src/get_challenges.rs b/starky2/src/get_challenges.rs
index 7e65a432..c7931ebf 100644
--- a/starky2/src/get_challenges.rs
+++ b/starky2/src/get_challenges.rs
@@ -21,7 +21,6 @@ use crate::stark::Stark;
 fn get_challenges<F, C, S, const D: usize>(
     challenger: &mut Challenger<F, C::Hasher>,
     stark: &S,
-    trace_cap: &MerkleCap<F, C::Hasher>,
     permutation_ctl_zs_cap: Option<&MerkleCap<F, C::Hasher>>,
     quotient_polys_cap: &MerkleCap<F, C::Hasher>,
     openings: &StarkOpeningSet<F, D>,
@@ -131,7 +130,6 @@ where
         let degree_bits = self.proof.recover_degree_bits(config);
 
         let StarkProof {
-            trace_cap,
             permutation_ctl_zs_cap,
             quotient_polys_cap,
             openings,
@@ -142,12 +140,12 @@ where
                     pow_witness,
                     ..
                 },
+            ..
         } = &self.proof;
 
         get_challenges::<F, C, S, D>(
             challenger,
             stark,
-            trace_cap,
             permutation_ctl_zs_cap.as_ref(),
             quotient_polys_cap,
             openings,
diff --git a/starky2/src/permutation.rs b/starky2/src/permutation.rs
index 881a67ed..a5601a7b 100644
--- a/starky2/src/permutation.rs
+++ b/starky2/src/permutation.rs
@@ -1,7 +1,5 @@
 //! Permutation arguments.
 
-use std::fmt::Debug;
-
 use itertools::Itertools;
 use plonky2::field::batch_util::batch_multiply_inplace;
 use plonky2::field::extension_field::{Extendable, FieldExtension};
diff --git a/starky2/src/prover.rs b/starky2/src/prover.rs
index 6dc94657..2ab1886d 100644
--- a/starky2/src/prover.rs
+++ b/starky2/src/prover.rs
@@ -514,8 +514,7 @@ fn test_it<'a, F, C, S, const D: usize>(
                 &lookup_check_data,
                 &mut consumer,
             );
-            let mut constraints_evals = consumer.accumulators();
-            constraints_evals
+            consumer.accumulators()
         })
         .collect::<Vec<_>>();
 
diff --git a/starky2/src/verifier.rs b/starky2/src/verifier.rs
index 2f7a628e..2c4a7fba 100644
--- a/starky2/src/verifier.rs
+++ b/starky2/src/verifier.rs
@@ -220,6 +220,7 @@ fn eval_l_1_and_l_last<F: Field>(log_n: usize, x: F) -> (F, F) {
 
 /// Utility function to check that all permutation data wrapped in `Option`s are `Some` iff
 /// the Stark uses a permutation argument.
+#[allow(dead_code)]
 fn check_permutation_options<
     F: RichField + Extendable<D>,
     C: GenericConfig<D, F = F>,