logos-storage/plonky2
1
0
Fork 0
mirror of https://github.com/logos-storage/plonky2.git synced 2026-05-02 08:13:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #381 from mir-protocol/obsolete_todos

Browse Source 
Remove obsolete todos
This commit is contained in:
wborgeaud 2021-12-02 18:29:03 +01:00 committed by GitHub
commit d361dffa5e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/field/cosets.rs
View File

@ -31,8 +31,6 @@ mod tests {
#[test] #[test]
fn distinct_cosets() { fn distinct_cosets() {
// TODO: Switch to a smaller test field so that collision rejection is likely to occur.
type F = GoldilocksField; type F = GoldilocksField;
const SUBGROUP_BITS: usize = 5; const SUBGROUP_BITS: usize = 5;
const NUM_SHIFTS: usize = 50; const NUM_SHIFTS: usize = 50;

7
src/gadgets/arithmetic.rs
View File

@ -184,13 +184,8 @@ impl<F: RichField + Extendable<D>, const D: usize> CircuitBuilder<F, D> {
} }
/// Add `n` `Target`s. /// Add `n` `Target`s.
// TODO: Can be made `D` times more efficient by using all wires of an `ArithmeticExtensionGate`.
pub fn add_many(&mut self, terms: &[Target]) -> Target { pub fn add_many(&mut self, terms: &[Target]) -> Target {
let terms_ext = terms terms.iter().fold(self.zero(), |acc, &t| self.add(acc, t))
.iter()
.map(|&t| self.convert_to_ext(t))
.collect::<Vec<_>>();
self.add_many_extension(&terms_ext).to_target_array()[0]
} }
/// Computes `x - y`. /// Computes `x - y`.

1
src/plonk/prover.rs
View File

@ -146,7 +146,6 @@ pub(crate) fn prove<F: RichField + Extendable<D>, const D: usize>(
.into_par_iter() .into_par_iter()
.flat_map(|mut quotient_poly| { .flat_map(|mut quotient_poly| {
quotient_poly.trim(); quotient_poly.trim();
// TODO: Return Result instead of panicking.
quotient_poly.pad(quotient_degree).expect( quotient_poly.pad(quotient_degree).expect(
"Quotient has failed, the vanishing polynomial is not divisible by `Z_H", "Quotient has failed, the vanishing polynomial is not divisible by `Z_H",
); );