Merge pull request #381 from mir-protocol/obsolete_todos

Remove obsolete todos
This commit is contained in:
wborgeaud 2021-12-02 18:29:03 +01:00 committed by GitHub
commit d361dffa5e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 9 deletions

View File

@ -31,8 +31,6 @@ mod tests {
#[test]
fn distinct_cosets() {
// TODO: Switch to a smaller test field so that collision rejection is likely to occur.
type F = GoldilocksField;
const SUBGROUP_BITS: usize = 5;
const NUM_SHIFTS: usize = 50;

View File

@ -184,13 +184,8 @@ impl<F: RichField + Extendable<D>, const D: usize> CircuitBuilder<F, D> {
}
/// Add `n` `Target`s.
// TODO: Can be made `D` times more efficient by using all wires of an `ArithmeticExtensionGate`.
pub fn add_many(&mut self, terms: &[Target]) -> Target {
let terms_ext = terms
.iter()
.map(|&t| self.convert_to_ext(t))
.collect::<Vec<_>>();
self.add_many_extension(&terms_ext).to_target_array()[0]
terms.iter().fold(self.zero(), |acc, &t| self.add(acc, t))
}
/// Computes `x - y`.

View File

@ -146,7 +146,6 @@ pub(crate) fn prove<F: RichField + Extendable<D>, const D: usize>(
.into_par_iter()
.flat_map(|mut quotient_poly| {
quotient_poly.trim();
// TODO: Return Result instead of panicking.
quotient_poly.pad(quotient_degree).expect(
"Quotient has failed, the vanishing polynomial is not divisible by `Z_H",
);