mirror of
https://github.com/logos-storage/plonky2.git
synced 2026-01-03 14:23:07 +00:00
Merge pull request #381 from mir-protocol/obsolete_todos
Remove obsolete todos
This commit is contained in:
commit
d361dffa5e
@ -31,8 +31,6 @@ mod tests {
|
||||
|
||||
#[test]
|
||||
fn distinct_cosets() {
|
||||
// TODO: Switch to a smaller test field so that collision rejection is likely to occur.
|
||||
|
||||
type F = GoldilocksField;
|
||||
const SUBGROUP_BITS: usize = 5;
|
||||
const NUM_SHIFTS: usize = 50;
|
||||
|
||||
@ -184,13 +184,8 @@ impl<F: RichField + Extendable<D>, const D: usize> CircuitBuilder<F, D> {
|
||||
}
|
||||
|
||||
/// Add `n` `Target`s.
|
||||
// TODO: Can be made `D` times more efficient by using all wires of an `ArithmeticExtensionGate`.
|
||||
pub fn add_many(&mut self, terms: &[Target]) -> Target {
|
||||
let terms_ext = terms
|
||||
.iter()
|
||||
.map(|&t| self.convert_to_ext(t))
|
||||
.collect::<Vec<_>>();
|
||||
self.add_many_extension(&terms_ext).to_target_array()[0]
|
||||
terms.iter().fold(self.zero(), |acc, &t| self.add(acc, t))
|
||||
}
|
||||
|
||||
/// Computes `x - y`.
|
||||
|
||||
@ -146,7 +146,6 @@ pub(crate) fn prove<F: RichField + Extendable<D>, const D: usize>(
|
||||
.into_par_iter()
|
||||
.flat_map(|mut quotient_poly| {
|
||||
quotient_poly.trim();
|
||||
// TODO: Return Result instead of panicking.
|
||||
quotient_poly.pad(quotient_degree).expect(
|
||||
"Quotient has failed, the vanishing polynomial is not divisible by `Z_H",
|
||||
);
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user