From cf3b6df0e4683b780eb3f96c3237f2926246c293 Mon Sep 17 00:00:00 2001 From: Nicholas Ward Date: Tue, 9 Nov 2021 16:36:29 -0800 Subject: [PATCH] addressed nits --- src/gadgets/arithmetic_u32.rs | 6 ++---- src/plonk/circuit_builder.rs | 4 ++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/gadgets/arithmetic_u32.rs b/src/gadgets/arithmetic_u32.rs index 22957075..ce7aa121 100644 --- a/src/gadgets/arithmetic_u32.rs +++ b/src/gadgets/arithmetic_u32.rs @@ -57,10 +57,8 @@ impl, const D: usize> CircuitBuilder { }; if let (Some(a), Some(b)) = (first_term_const, z_const) { - let sum_u64 = (a + b).to_canonical_u64(); - let (low_u64, high_u64) = (sum_u64 % (1u64 << 32), sum_u64 >> 32); - let low = F::from_canonical_u64(low_u64); - let high = F::from_canonical_u64(high_u64); + let sum = (a + b).to_canonical_u64(); + let (low, high) = (sum as u32, (sum >> 32) as u32); return Some((self.constant_u32(low), self.constant_u32(high))); } diff --git a/src/plonk/circuit_builder.rs b/src/plonk/circuit_builder.rs index 3296061c..33709e32 100644 --- a/src/plonk/circuit_builder.rs +++ b/src/plonk/circuit_builder.rs @@ -318,8 +318,8 @@ impl, const D: usize> CircuitBuilder { } /// Returns a U32Target for the value `c`, which is assumed to be at most 32 bits. - pub fn constant_u32(&mut self, c: F) -> U32Target { - U32Target(self.constant(c)) + pub fn constant_u32(&mut self, c: u32) -> U32Target { + U32Target(self.constant(F::from_canonical_u32(c))) } /// If the given target is a constant (i.e. it was created by the `constant(F)` method), returns