logos-storage/plonky2
1
0
Fork 0
mirror of https://github.com/logos-storage/plonky2.git synced 2026-01-08 08:43:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reduce number of lookup accesses

Browse Source
This commit is contained in:
Robin Salen 2023-07-06 11:19:35 -04:00
parent b32345cd52
commit cbb3da15c9
No known key found for this signature in database
GPG Key ID: F98FD38F65687358
4 changed files with 31 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
plonky2/src/gates/lookup.rs
View File

@ -170,23 +170,25 @@ impl<F: RichField + Extendable<D>, const D: usize> SimpleGenerator<F, D> for Loo
let get_wire = |wire: usize| -> F { witness.get_target(Target::wire(self.row, wire)) };
let input_val = get_wire(LookupGate::wire_ith_looking_inp(self.slot_nb));
let output_val = if input_val
== F::from_canonical_u16(self.lut[input_val.to_canonical_u64() as usize].0)
{
F::from_canonical_u16(self.lut[input_val.to_canonical_u64() as usize].1)
} else {
let mut cur_idx = 0;
while input_val != F::from_canonical_u16(self.lut[cur_idx].0)
&& cur_idx < self.lut.len()
{
cur_idx += 1;
}
assert!(cur_idx < self.lut.len(), "Incorrect input value provided");
F::from_canonical_u16(self.lut[cur_idx].1)
};
let (input, output) = self.lut[input_val.to_canonical_u64() as usize];
if input_val == F::from_canonical_u16(input) {
let output_val = F::from_canonical_u16(output);
let out_wire = Target::wire(self.row, LookupGate::wire_ith_looking_out(self.slot_nb));
out_buffer.set_target(out_wire, output_val);
let out_wire = Target::wire(self.row, LookupGate::wire_ith_looking_out(self.slot_nb));
out_buffer.set_target(out_wire, output_val);
} else {
for (input, output) in self.lut.iter() {
if input_val == F::from_canonical_u16(*input) {
let output_val = F::from_canonical_u16(*output);
let out_wire =
Target::wire(self.row, LookupGate::wire_ith_looking_out(self.slot_nb));
out_buffer.set_target(out_wire, output_val);
return;
}
}
panic!("Incorrect input value provided");
};
}
fn serialize(&self, dst: &mut Vec<u8>, cd: &CommonCircuitData<F, D>) -> IoResult<()> {

11
plonky2/src/gates/lookup_table.rs
View File

@ -193,14 +193,9 @@ impl<F: RichField + Extendable<D>, const D: usize> SimpleGenerator<F, D> for Loo
Target::wire(self.row, LookupTableGate::wire_ith_looked_out(self.slot_nb));
if slot < self.lut.len() {
out_buffer.set_target(
slot_input_target,
F::from_canonical_usize(self.lut[slot].0 as usize),
);
out_buffer.set_target(
slot_output_target,
F::from_canonical_usize(self.lut[slot].1.into()),
);
let (input, output) = self.lut[slot];
out_buffer.set_target(slot_input_target, F::from_canonical_usize(input as usize));
out_buffer.set_target(slot_output_target, F::from_canonical_usize(output as usize));
} else {
// Pad with zeros.
out_buffer.set_target(slot_input_target, F::ZERO);

7
plonky2/src/plonk/prover.rs
View File

@ -71,15 +71,14 @@ pub fn set_lookup_wires<
let remaining_slots = (num_entries
- (prover_data.lut_to_lookups[lut_index].len() % num_entries))
% num_entries;
let first_inp_value = F::from_canonical_u16(common_data.luts[lut_index][0].0);
let first_out_value = F::from_canonical_u16(common_data.luts[lut_index][0].1);
let (first_inp_value, first_out_value) = common_data.luts[lut_index][0];
for slot in (num_entries - remaining_slots)..num_entries {
let inp_target =
Target::wire(last_lut_gate - 1, LookupGate::wire_ith_looking_inp(slot));
let out_target =
Target::wire(last_lut_gate - 1, LookupGate::wire_ith_looking_out(slot));
pw.set_target(inp_target, first_inp_value);
pw.set_target(out_target, first_out_value);
pw.set_target(inp_target, F::from_canonical_u16(first_inp_value));
pw.set_target(out_target, F::from_canonical_u16(first_out_value));
multiplicities[0] += 1;
}

20
plonky2/src/plonk/vanishing_poly.rs
View File

@ -37,11 +37,8 @@ pub(crate) fn get_lut_poly<F: RichField + Extendable<D>, const D: usize>(
let b = deltas[LookupChallenges::ChallengeB as usize];
let mut coeffs = Vec::new();
let n = common_data.luts[lut_index].len();
for i in 0..n {
coeffs.push(
F::from_canonical_u16(common_data.luts[lut_index][i].0)
+ b * F::from_canonical_u16(common_data.luts[lut_index][i].1),
);
for (input, output) in common_data.luts[lut_index].iter() {
coeffs.push(F::from_canonical_u16(*input) + b * F::from_canonical_u16(*output));
}
coeffs.append(&mut vec![F::ZERO; degree - n]);
coeffs.reverse();
@ -767,14 +764,11 @@ pub(crate) fn get_lut_poly_circuit<F: RichField + Extendable<D>, const D: usize>
let b = deltas[LookupChallenges::ChallengeB as usize];
let delta = deltas[LookupChallenges::ChallengeDelta as usize];
let n = common_data.luts[lut_index].len();
let mut coeffs: Vec<Target> = (0..n)
.map(|i| {
let temp =
builder.mul_const(F::from_canonical_u16(common_data.luts[lut_index][i].1), b);
builder.add_const(
temp,
F::from_canonical_u16(common_data.luts[lut_index][i].0),
)
let mut coeffs: Vec<Target> = common_data.luts[lut_index]
.iter()
.map(|(input, output)| {
let temp = builder.mul_const(F::from_canonical_u16(*output), b);
builder.add_const(temp, F::from_canonical_u16(*input))
})
.collect();
for _ in n..degree {