logos-storage/plonky2
1
0
Fork 0
mirror of https://github.com/logos-storage/plonky2.git synced 2026-05-01 07:43:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix minor bug where constant_affine_point is called on zero

Browse Source
This commit is contained in:
wborgeaud 2022-07-23 09:18:41 +02:00
parent 60227b9828
commit bbc2ff27ab
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ecdsa/src/gadgets/curve_fixed_base.rs
View File

@ -40,14 +40,18 @@ pub fn fixed_base_curve_mul_circuit<C: Curve, F: RichField + Extendable<D>, cons
// `s * P = sum s_i * P_i` with `P_i = (16^i) * P` and `s = sum s_i * (16^i)`. // `s * P = sum s_i * P_i` with `P_i = (16^i) * P` and `s = sum s_i * (16^i)`.
for (limb, point) in limbs.into_iter().zip(scaled_base) { for (limb, point) in limbs.into_iter().zip(scaled_base) {
// `muls_point[t] = t * P_i` for `t=0..16`. // `muls_point[t] = t * P_i` for `t=0..16`.
let muls_point = (0..16) let mut muls_point = (0..16)
.scan(AffinePoint::ZERO, |acc, _| { .scan(AffinePoint::ZERO, |acc, _| {
let tmp = *acc; let tmp = *acc;
*acc = (point + *acc).to_affine(); *acc = (point + *acc).to_affine();
Some(tmp) Some(tmp)
}) })
// First element if zero, so we skip it since `constant_affine_point` takes non-zero input.
.skip(1)
.map(|p| builder.constant_affine_point(p)) .map(|p| builder.constant_affine_point(p))
.collect::<Vec<_>>(); .collect::<Vec<_>>();
// We add back a point in position 0. `limb == zero` is checked below, so this point can be arbitrary.
muls_point.insert(0, muls_point[0].clone());
let is_zero = builder.is_equal(limb, zero); let is_zero = builder.is_equal(limb, zero);
let should_add = builder.not(is_zero); let should_add = builder.not(is_zero);
// `r = s_i * P_i` // `r = s_i * P_i`