From ba9aa14f515e14612c78de9069e3887159a59cf7 Mon Sep 17 00:00:00 2001 From: wborgeaud Date: Mon, 18 Jul 2022 14:00:20 +0200 Subject: [PATCH] PR feedback --- evm/src/cpu/kernel/asm/secp256k1/lift_x.asm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/evm/src/cpu/kernel/asm/secp256k1/lift_x.asm b/evm/src/cpu/kernel/asm/secp256k1/lift_x.asm index 34133e60..cd392b61 100644 --- a/evm/src/cpu/kernel/asm/secp256k1/lift_x.asm +++ b/evm/src/cpu/kernel/asm/secp256k1/lift_x.asm @@ -60,8 +60,9 @@ ADDMOD %endmacro -// Returns sqrt(x). Computed as x^(q+1)/4, with q the Secp base field order. -/// To replace with more efficient method using non-determinism later. +// Returns a square root of x if one exists, otherwise an undefined value. +// Computed as x^(q+1)/4, with q the Secp base field order. +// To replace with more efficient method using non-determinism later. %macro sqrt_secp_base // stack: x DUP1