PR feedback

This commit is contained in:
wborgeaud 2021-06-29 09:49:05 +02:00
parent 636d8bef07
commit 9a352193ed
2 changed files with 4 additions and 10 deletions

View File

@ -230,8 +230,7 @@ impl<F: Extendable<D>, const D: usize> CircuitBuilder<F, D> {
product
}
/// Like `mul_add`, but for `ExtensionTarget`s. Note that, unlike `mul_add`, this has no
/// performance benefit over separate muls and adds.
/// Like `mul_add`, but for `ExtensionTarget`s.
pub fn mul_add_extension(
&mut self,
a: ExtensionTarget<D>,
@ -385,12 +384,7 @@ impl<F: Extendable<D>, const D: usize> SimpleGenerator<F> for QuotientGeneratorE
let dem = witness.get_extension_target(self.denominator);
let quotient = num / dem;
let mut pw = PartialWitness::new();
for i in 0..D {
pw.set_target(
self.quotient.to_target_array()[i],
quotient.to_basefield_array()[i],
);
}
pw.set_extension_target(self.quotient, quotient);
pw
}

View File

@ -61,7 +61,7 @@ impl<F: Extendable<D>, const D: usize> Gate<F, D> for ArithmeticExtensionGate<D>
let computed_output_0 =
fixed_multiplicand * multiplicand_0 * const_0.into() + addend_0 * const_1.into();
let computed_output_1 =
fixed_multiplicand * multiplicand_1 * const_1.into() + addend_1 * const_1.into();
fixed_multiplicand * multiplicand_1 * const_0.into() + addend_1 * const_1.into();
let mut constraints = (output_0 - computed_output_0).to_basefield_array().to_vec();
constraints.extend((output_1 - computed_output_1).to_basefield_array());
@ -115,7 +115,7 @@ impl<F: Extendable<D>, const D: usize> Gate<F, D> for ArithmeticExtensionGate<D>
}
fn num_wires(&self) -> usize {
28
7 * D
}
fn num_constants(&self) -> usize {