From aad56c6603308e7a18519e49312cca9fa4fa4e89 Mon Sep 17 00:00:00 2001 From: Sebastien La Duca Date: Fri, 29 Apr 2022 10:50:02 +0200 Subject: [PATCH 1/4] make recover_degree_bits_public --- starky/src/proof.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/starky/src/proof.rs b/starky/src/proof.rs index dba3db3e..32b9b561 100644 --- a/starky/src/proof.rs +++ b/starky/src/proof.rs @@ -33,7 +33,7 @@ pub struct StarkProof, C: GenericConfig, impl, C: GenericConfig, const D: usize> StarkProof { /// Recover the length of the trace from a STARK proof and a STARK config. - pub(crate) fn recover_degree_bits(&self, config: &StarkConfig) -> usize { + pub fn recover_degree_bits(&self, config: &StarkConfig) -> usize { let initial_merkle_proof = &self.opening_proof.query_round_proofs[0] .initial_trees_proof .evals_proofs[0] From 5b90d9123509baac0d0e77b2fb5757ff462073be Mon Sep 17 00:00:00 2001 From: Sebastien La Duca Date: Fri, 29 Apr 2022 15:39:54 +0200 Subject: [PATCH 2/4] add doc explaining ordering in --- starky/src/stark.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/starky/src/stark.rs b/starky/src/stark.rs index 72614574..b2efc4ed 100644 --- a/starky/src/stark.rs +++ b/starky/src/stark.rs @@ -61,6 +61,8 @@ pub trait Stark, const D: usize>: Sync { /// Evaluate constraints at a vector of points from the degree `D` extension field. This is like /// `eval_ext`, except in the context of a recursive circuit. + /// Note: constraints must be added through`yeld_constr.constraint(builder, constraint)` in the + /// same order as they are given in `eval_packed_generic`. fn eval_ext_recursively( &self, builder: &mut CircuitBuilder, From b17e2c8db57763a6dfbd654fce06c5a87c35ee97 Mon Sep 17 00:00:00 2001 From: Sebastien La Duca Date: Fri, 29 Apr 2022 15:47:00 +0200 Subject: [PATCH 3/4] fmt --- starky/src/stark.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/starky/src/stark.rs b/starky/src/stark.rs index b2efc4ed..a130d283 100644 --- a/starky/src/stark.rs +++ b/starky/src/stark.rs @@ -61,7 +61,7 @@ pub trait Stark, const D: usize>: Sync { /// Evaluate constraints at a vector of points from the degree `D` extension field. This is like /// `eval_ext`, except in the context of a recursive circuit. - /// Note: constraints must be added through`yeld_constr.constraint(builder, constraint)` in the + /// Note: constraints must be added through`yeld_constr.constraint(builder, constraint)` in the /// same order as they are given in `eval_packed_generic`. fn eval_ext_recursively( &self, From 737e237ee5e485d0d80711fa60d43e88a0087b1e Mon Sep 17 00:00:00 2001 From: Sebastien La Duca Date: Fri, 29 Apr 2022 22:27:03 +0200 Subject: [PATCH 4/4] make recover_degree_bits public for StarkProofTarget --- starky/src/proof.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/starky/src/proof.rs b/starky/src/proof.rs index 32b9b561..afefdd96 100644 --- a/starky/src/proof.rs +++ b/starky/src/proof.rs @@ -53,7 +53,7 @@ pub struct StarkProofTarget { impl StarkProofTarget { /// Recover the length of the trace from a STARK proof and a STARK config. - pub(crate) fn recover_degree_bits(&self, config: &StarkConfig) -> usize { + pub fn recover_degree_bits(&self, config: &StarkConfig) -> usize { let initial_merkle_proof = &self.opening_proof.query_round_proofs[0] .initial_trees_proof .evals_proofs[0]