Merge pull request #1223 from succinctlabs/uma/change-witness-visibility

Changed visibilities in `iop/generator` to allow for implementing `generate_partial_witness` outside of crate
This commit is contained in:
Nicholas Ward 2023-09-08 08:35:35 -07:00 committed by GitHub
commit 90ea0318fb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions

View File

@ -148,7 +148,7 @@ impl<F: RichField + Extendable<D>, const D: usize> Debug for WitnessGeneratorRef
/// Values generated by a generator invocation.
#[derive(Debug)]
pub struct GeneratedValues<F: Field> {
pub(crate) target_values: Vec<(Target, F)>,
pub target_values: Vec<(Target, F)>,
}
impl<F: Field> From<Vec<(Target, F)>> for GeneratedValues<F> {

View File

@ -265,7 +265,7 @@ impl<F: Field> MatrixWitness<F> {
#[derive(Clone, Debug, Default)]
pub struct PartialWitness<F: Field> {
pub(crate) target_values: HashMap<Target, F>,
pub target_values: HashMap<Target, F>,
}
impl<F: Field> PartialWitness<F> {
@ -317,7 +317,7 @@ impl<'a, F: Field> PartitionWitness<'a, F> {
/// Set a `Target`. On success, returns the representative index of the newly-set target. If the
/// target was already set, returns `None`.
pub(crate) fn set_target_returning_rep(&mut self, target: Target, value: F) -> Option<usize> {
pub fn set_target_returning_rep(&mut self, target: Target, value: F) -> Option<usize> {
let rep_index = self.representative_map[self.target_index(target)];
let rep_value = &mut self.values[rep_index];
if let Some(old_value) = *rep_value {