diff --git a/plonky2/src/gadgets/curve_fixed_base.rs b/plonky2/src/gadgets/curve_fixed_base.rs index 70def6bc..4ba8d11e 100644 --- a/plonky2/src/gadgets/curve_fixed_base.rs +++ b/plonky2/src/gadgets/curve_fixed_base.rs @@ -18,8 +18,8 @@ impl, const D: usize> CircuitBuilder { base: &AffinePoint, scalar: &NonNativeTarget, ) -> AffinePointTarget { - let doubled_base = (0..scalar.value.limbs.len() * 8).scan(base.clone(), |acc, _| { - let tmp = acc.clone(); + let doubled_base = (0..scalar.value.limbs.len() * 8).scan(*base, |acc, _| { + let tmp = *acc; for _ in 0..4 { *acc = acc.double(); } @@ -34,11 +34,11 @@ impl, const D: usize> CircuitBuilder { )); let rando = (CurveScalar(hash_0_scalar) * C::GENERATOR_PROJECTIVE).to_affine(); let zero = self.zero(); - let mut result = self.constant_affine_point(rando.clone()); + let mut result = self.constant_affine_point(rando); for (limb, point) in bits.into_iter().zip(doubled_base) { let mul_point = (0..16) .scan(AffinePoint::ZERO, |acc, _| { - let tmp = acc.clone(); + let tmp = *acc; *acc = (point + *acc).to_affine(); Some(tmp) }) diff --git a/plonky2/src/gadgets/glv.rs b/plonky2/src/gadgets/glv.rs index 8447137d..f0c4704b 100644 --- a/plonky2/src/gadgets/glv.rs +++ b/plonky2/src/gadgets/glv.rs @@ -49,7 +49,7 @@ impl, const D: usize> CircuitBuilder { let s = self.constant_nonnative(GLV_S); let mut should_be_k = self.mul_nonnative(&s, &k2_raw); should_be_k = self.add_nonnative(&should_be_k, &k1_raw); - self.connect_nonnative(&should_be_k, &k); + self.connect_nonnative(&should_be_k, k); (k1, k2, k1_neg, k2_neg) } @@ -68,7 +68,7 @@ impl, const D: usize> CircuitBuilder { y: p.y.clone(), }; - let p_neg = self.curve_conditional_neg(&p, k1_neg); + let p_neg = self.curve_conditional_neg(p, k1_neg); let sp_neg = self.curve_conditional_neg(&sp, k2_neg); self.curve_msm(&p_neg, &sp_neg, &k1.value, &k2.value) }