From 8c96b8d2db84c99917172e4eb500fd5a8f8dbd46 Mon Sep 17 00:00:00 2001
From: wborgeaud <williamborgeaud@gmail.com>
Date: Fri, 23 Sep 2022 16:36:17 +0200
Subject: [PATCH] Comment

---
 evm/src/proof.rs               |  2 ++
 plonky2/src/hash/hash_types.rs | 10 ----------
 plonky2/src/plonk/config.rs    |  1 -
 3 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/evm/src/proof.rs b/evm/src/proof.rs
index 3b2d988b..2b75017a 100644
--- a/evm/src/proof.rs
+++ b/evm/src/proof.rs
@@ -40,6 +40,8 @@ pub(crate) struct AllProofChallenges<F: RichField + Extendable<D>, const D: usiz
 }
 
 pub(crate) struct AllChallengerState<F: RichField + Extendable<D>, const D: usize> {
+    /// Sponge state of the challenger before starting each proof,
+    /// along with the final state after all proofs are done. This final state isn't strictly needed.
     pub states: [[F; SPONGE_WIDTH]; NUM_TABLES + 1],
     pub ctl_challenges: GrandProductChallengeSet<F>,
 }
diff --git a/plonky2/src/hash/hash_types.rs b/plonky2/src/hash/hash_types.rs
index 955f539a..14303ad3 100644
--- a/plonky2/src/hash/hash_types.rs
+++ b/plonky2/src/hash/hash_types.rs
@@ -78,12 +78,6 @@ impl<F: RichField> GenericHashOut<F> for HashOut<F> {
     fn to_vec(&self) -> Vec<F> {
         self.elements.to_vec()
     }
-
-    fn from_vec(v: &[F]) -> Self {
-        Self {
-            elements: v.try_into().unwrap(),
-        }
-    }
 }
 
 impl<F: Field> Default for HashOut<F> {
@@ -154,10 +148,6 @@ impl<F: RichField, const N: usize> GenericHashOut<F> for BytesHash<N> {
             })
             .collect()
     }
-
-    fn from_vec(_v: &[F]) -> Self {
-        todo!()
-    }
 }
 
 impl<const N: usize> Serialize for BytesHash<N> {
diff --git a/plonky2/src/plonk/config.rs b/plonky2/src/plonk/config.rs
index 51dacdde..f55bad1f 100644
--- a/plonky2/src/plonk/config.rs
+++ b/plonky2/src/plonk/config.rs
@@ -20,7 +20,6 @@ pub trait GenericHashOut<F: RichField>:
     fn from_bytes(bytes: &[u8]) -> Self;
 
     fn to_vec(&self) -> Vec<F>;
-    fn from_vec(v: &[F]) -> Self;
 }
 
 /// Trait for hash functions.