From 8a56af93c2e921f3fad3028230cc38dc48801d54 Mon Sep 17 00:00:00 2001 From: Nicholas Ward Date: Mon, 31 Jan 2022 10:20:05 -0800 Subject: [PATCH] TODOs --- plonky2/src/gadgets/nonnative.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/plonky2/src/gadgets/nonnative.rs b/plonky2/src/gadgets/nonnative.rs index 8ce5933c..637eaccc 100644 --- a/plonky2/src/gadgets/nonnative.rs +++ b/plonky2/src/gadgets/nonnative.rs @@ -85,6 +85,8 @@ impl, const D: usize> CircuitBuilder { let sum_actual = self.add_biguint(&sum.value, &mod_times_overflow); self.connect_biguint(&sum_expected, &sum_actual); + // Range-check result. + // TODO: can potentially leave unreduced until necessary (e.g. when connecting values). let cmp = self.cmp_biguint(&sum.value, &modulus); let one = self.one(); self.connect(cmp.target, one); @@ -137,6 +139,8 @@ impl, const D: usize> CircuitBuilder { let sum_actual = self.add_biguint(&sum.value, &mod_times_overflow); self.connect_biguint(&sum_expected, &sum_actual); + // Range-check result. + // TODO: can potentially leave unreduced until necessary (e.g. when connecting values). let cmp = self.cmp_biguint(&sum.value, &modulus); let one = self.one(); self.connect(cmp.target, one);