From 88f64072efc053fcb7415982ffa141d59cf22734 Mon Sep 17 00:00:00 2001 From: Daniel Lubarov Date: Fri, 9 Dec 2022 08:56:49 -0800 Subject: [PATCH] Comments --- evm/src/memory/memory_stark.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/evm/src/memory/memory_stark.rs b/evm/src/memory/memory_stark.rs index 48a483ed..8103f883 100644 --- a/evm/src/memory/memory_stark.rs +++ b/evm/src/memory/memory_stark.rs @@ -120,10 +120,13 @@ impl, const D: usize> MemoryStark { /// Generate most of the trace rows. Excludes a few columns like `COUNTER`, which are generated /// later, after transposing to column-major form. fn generate_trace_row_major(&self, mut memory_ops: Vec) -> Vec<[F; NUM_COLUMNS]> { + // fill_gaps expects an ordered list of operations. memory_ops.sort_by_key(MemoryOp::sorting_key); Self::fill_gaps(&mut memory_ops); + Self::pad_memory_ops(&mut memory_ops); + // fill_gaps may have added operations at the end which break the order, so sort again. memory_ops.sort_by_key(MemoryOp::sorting_key); let mut trace_rows = memory_ops