From 87ad5714aa8938633a7e210c5fa4308296bcb87c Mon Sep 17 00:00:00 2001 From: Nicholas Ward Date: Tue, 14 Mar 2023 12:20:38 -0700 Subject: [PATCH] addressed comments --- evm/src/cpu/kernel/asm/bignum/shr.asm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/evm/src/cpu/kernel/asm/bignum/shr.asm b/evm/src/cpu/kernel/asm/bignum/shr.asm index 69d32b07..5e3a56ef 100644 --- a/evm/src/cpu/kernel/asm/bignum/shr.asm +++ b/evm/src/cpu/kernel/asm/bignum/shr.asm @@ -2,6 +2,7 @@ // All integers must be under a given length bound, and are padded with leading zeroes. // Shifts a given bignum right by one bit (in place). +// Assumes that len > 0. global shr_bignum: // stack: len, start_loc, retdest DUP2 @@ -30,7 +31,7 @@ shr_loop: // stack: carry, a[i] >> 1, i, new_carry, start_loc, retdest %shl_const(127) // stack: carry << 127, a[i] >> 1, i, new_carry, start_loc, retdest - OR + ADD // stack: carry << 127 | a[i] >> 1, i, new_carry, start_loc, retdest DUP2 // stack: i, carry << 127 | a[i] >> 1, i, new_carry, start_loc, retdest