From 7d4e79f069aa5e043042b1f73bfb6f8d3717867d Mon Sep 17 00:00:00 2001
From: wborgeaud <williamborgeaud@gmail.com>
Date: Fri, 18 Jun 2021 11:22:38 +0200
Subject: [PATCH] Clippy

---
 src/fri/verifier.rs          | 2 +-
 src/polynomial/commitment.rs | 4 +---
 src/polynomial/division.rs   | 7 +++----
 3 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/src/fri/verifier.rs b/src/fri/verifier.rs
index 486e7174..6320505e 100644
--- a/src/fri/verifier.rs
+++ b/src/fri/verifier.rs
@@ -2,7 +2,7 @@ use anyhow::{ensure, Result};
 
 use crate::field::extension_field::{flatten, Extendable, FieldExtension, Frobenius};
 use crate::field::field::Field;
-use crate::field::lagrange::{barycentric_weights, interpolant, interpolate, interpolate2};
+use crate::field::lagrange::{barycentric_weights, interpolate, interpolate2};
 use crate::fri::FriConfig;
 use crate::hash::hash_n_to_1;
 use crate::merkle_proofs::verify_merkle_proof;
diff --git a/src/polynomial/commitment.rs b/src/polynomial/commitment.rs
index 1b7d611b..ce978d96 100644
--- a/src/polynomial/commitment.rs
+++ b/src/polynomial/commitment.rs
@@ -4,7 +4,7 @@ use rayon::prelude::*;
 use crate::field::extension_field::Extendable;
 use crate::field::extension_field::{FieldExtension, Frobenius};
 use crate::field::field::Field;
-use crate::field::lagrange::{interpolant, interpolant2};
+use crate::field::lagrange::interpolant2;
 use crate::fri::{prover::fri_proof, verifier::verify_fri_proof, FriConfig};
 use crate::merkle_tree::MerkleTree;
 use crate::plonk_challenger::Challenger;
@@ -120,8 +120,6 @@ impl<F: Field> ListPolynomialCommitment<F> {
             .iter()
             .flat_map(|&i| &commitments[i].polynomials)
             .map(|p| p.to_extension());
-        let single_os = [&os.constants, &os.plonk_s_sigmas, &os.quotient_polys];
-        let single_evals = single_os.iter().flat_map(|v| v.iter());
         let single_composition_poly = reduce_polys_with_iter(single_polys, &mut alpha_powers);
 
         let single_quotient = Self::compute_quotient1(zeta, single_composition_poly);
diff --git a/src/polynomial/division.rs b/src/polynomial/division.rs
index db1606af..50e1f8a6 100644
--- a/src/polynomial/division.rs
+++ b/src/polynomial/division.rs
@@ -26,7 +26,7 @@ impl<F: Field> PolynomialCoeffs<F> {
                 .to_vec()
                 .into();
             let mut q = rev_q.rev();
-            let mut qb = &q * b;
+            let qb = &q * b;
             let mut r = self - &qb;
             q.trim();
             r.trim();
@@ -59,8 +59,7 @@ impl<F: Field> PolynomialCoeffs<F> {
                 quotient.coeffs[cur_q_degree] = cur_q_coeff;
 
                 for (i, &div_coeff) in b.coeffs.iter().enumerate() {
-                    remainder.coeffs[cur_q_degree + i] =
-                        remainder.coeffs[cur_q_degree + i] - (cur_q_coeff * div_coeff);
+                    remainder.coeffs[cur_q_degree + i] -= cur_q_coeff * div_coeff;
                 }
                 remainder.trim();
             }
@@ -97,7 +96,7 @@ impl<F: Field> PolynomialCoeffs<F> {
         let denominators = (0..a_eval.len())
             .map(|i| {
                 if i != 0 {
-                    root_pow = root_pow * root_n;
+                    root_pow *= root_n;
                 }
                 denominator_g * root_pow - F::ONE
             })