logos-storage/plonky2
1
0
Fork 0
mirror of https://github.com/logos-storage/plonky2.git synced 2026-05-02 08:13:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant constraints (#568)

Browse Source
This commit is contained in:
Jacqueline Nabaglo 2022-06-15 11:27:40 -07:00 committed by GitHub
parent 31435944f1
commit 7cbce7bf6d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
evm/src/cpu/decode.rs
View File

@ -163,10 +163,6 @@ pub fn eval_packed_generic<P: PackedField>(
) { ) {
let cycle_filter = lv[columns::IS_CPU_CYCLE]; let cycle_filter = lv[columns::IS_CPU_CYCLE];
// If cycle_filter = 0, then we require is_eq = 0 and is_iszero = 0.
yield_constr.constraint((cycle_filter - P::ONES) * lv[columns::IS_EQ]);
yield_constr.constraint((cycle_filter - P::ONES) * lv[columns::IS_ISZERO]);
// Ensure that the opcode bits are valid: each has to be either 0 or 1, and they must match // Ensure that the opcode bits are valid: each has to be either 0 or 1, and they must match
// the opcode. Note that this also validates that this implicitly range-checks the opcode. // the opcode. Note that this also validates that this implicitly range-checks the opcode.
let bits = columns::OPCODE_BITS.map(|i| lv[i]); let bits = columns::OPCODE_BITS.map(|i| lv[i]);
@ -214,12 +210,6 @@ pub fn eval_ext_circuit<F: RichField + Extendable<D>, const D: usize>(
) { ) {
let cycle_filter = lv[columns::IS_CPU_CYCLE]; let cycle_filter = lv[columns::IS_CPU_CYCLE];
// If cycle_filter = 0, then we require is_eq = 0 and is_iszero = 0.
for flag in [lv[columns::IS_EQ], lv[columns::IS_ISZERO]] {
let constr = builder.mul_sub_extension(cycle_filter, flag, flag);
yield_constr.constraint(builder, constr);
}
// Ensure that the opcode bits are valid: each has to be either 0 or 1, and they must match // Ensure that the opcode bits are valid: each has to be either 0 or 1, and they must match
// the opcode. Note that this also validates that this implicitly range-checks the opcode. // the opcode. Note that this also validates that this implicitly range-checks the opcode.
let bits = columns::OPCODE_BITS.map(|i| lv[i]); let bits = columns::OPCODE_BITS.map(|i| lv[i]);