logos-storage/plonky2
1
0
Fork 0
mirror of https://github.com/logos-storage/plonky2.git synced 2026-01-05 23:33:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix failing byte constraint (#1135)

Browse Source
This commit is contained in:
Robin Salen 2023-07-17 12:45:07 -04:00 committed by GitHub
parent 152e395903
commit 7ba051f4c7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
evm/src/arithmetic/byte.rs
View File

@ -260,7 +260,7 @@ pub fn eval_packed<P: PackedField>(
let expected_out_byte = tree[15]; let expected_out_byte = tree[15];
// Sum all higher limbs; sum will be non-zero iff idx >= 32. // Sum all higher limbs; sum will be non-zero iff idx >= 32.
let hi_limb_sum = idx0_hi + idx[1..].iter().copied().sum::<P>(); let hi_limb_sum = lv[BYTE_IDX_DECOMP_HI] + idx[1..].iter().copied().sum::<P>();
let idx_is_large = lv[BYTE_IDX_IS_LARGE]; let idx_is_large = lv[BYTE_IDX_IS_LARGE];
// idx_is_large is 0 or 1 // idx_is_large is 0 or 1
@ -381,7 +381,7 @@ pub fn eval_ext_circuit<F: RichField + Extendable<D>, const D: usize>(
yield_constr.constraint(builder, t); yield_constr.constraint(builder, t);
let expected_out_byte = tree[15]; let expected_out_byte = tree[15];
let mut hi_limb_sum = idx0_hi; let mut hi_limb_sum = lv[BYTE_IDX_DECOMP_HI];
for i in 1..N_LIMBS { for i in 1..N_LIMBS {
hi_limb_sum = builder.add_extension(hi_limb_sum, idx[i]); hi_limb_sum = builder.add_extension(hi_limb_sum, idx[i]);
} }