diff --git a/ecdsa/Cargo.toml b/ecdsa/Cargo.toml index 59ad9ee3..a7e1024b 100644 --- a/ecdsa/Cargo.toml +++ b/ecdsa/Cargo.toml @@ -14,6 +14,4 @@ itertools = "0.10.0" rayon = "1.5.1" serde = { version = "1.0", features = ["derive"] } anyhow = "1.0.40" -rand = "0.8.4" -#env_logger = "0.9.0" -#log = "0.4.14" +rand = "0.8.4" \ No newline at end of file diff --git a/ecdsa/src/gadgets/biguint.rs b/ecdsa/src/gadgets/biguint.rs index 5c077747..0c08814c 100644 --- a/ecdsa/src/gadgets/biguint.rs +++ b/ecdsa/src/gadgets/biguint.rs @@ -42,17 +42,17 @@ pub trait CircuitBuilderBiguint, const D: usize> { fn add_virtual_biguint_target(&mut self, num_limbs: usize) -> BigUintTarget; - // Add two `BigUintTarget`s. + /// Add two `BigUintTarget`s. fn add_biguint(&mut self, a: &BigUintTarget, b: &BigUintTarget) -> BigUintTarget; - // Subtract two `BigUintTarget`s. We assume that the first is larger than the second. + /// Subtract two `BigUintTarget`s. We assume that the first is larger than the second. fn sub_biguint(&mut self, a: &BigUintTarget, b: &BigUintTarget) -> BigUintTarget; fn mul_biguint(&mut self, a: &BigUintTarget, b: &BigUintTarget) -> BigUintTarget; fn mul_biguint_by_bool(&mut self, a: &BigUintTarget, b: BoolTarget) -> BigUintTarget; - // Returns x * y + z. This is no more efficient than mul-then-add; it's purely for convenience (only need to call one CircuitBuilder function). + /// Returns x * y + z. This is no more efficient than mul-then-add; it's purely for convenience (only need to call one CircuitBuilder function). fn mul_add_biguint( &mut self, x: &BigUintTarget, @@ -133,7 +133,6 @@ impl, const D: usize> CircuitBuilderBiguint BigUintTarget { limbs } } - // Add two `BigUintTarget`s. fn add_biguint(&mut self, a: &BigUintTarget, b: &BigUintTarget) -> BigUintTarget { let num_limbs = a.num_limbs().max(b.num_limbs()); @@ -158,7 +157,6 @@ impl, const D: usize> CircuitBuilderBiguint } } - // Subtract two `BigUintTarget`s. We assume that the first is larger than the second. fn sub_biguint(&mut self, a: &BigUintTarget, b: &BigUintTarget) -> BigUintTarget { let (a, b) = self.pad_biguints(a, b); let num_limbs = a.limbs.len(); @@ -216,7 +214,6 @@ impl, const D: usize> CircuitBuilderBiguint } } - // Returns x * y + z. This is no more efficient than mul-then-add; it's purely for convenience (only need to call one CircuitBuilder function). fn mul_add_biguint( &mut self, x: &BigUintTarget, diff --git a/ecdsa/src/gadgets/curve.rs b/ecdsa/src/gadgets/curve.rs index e8a277c4..e511973b 100644 --- a/ecdsa/src/gadgets/curve.rs +++ b/ecdsa/src/gadgets/curve.rs @@ -50,7 +50,7 @@ pub trait CircuitBuilderCurve, const D: usize> { n: usize, ) -> AffinePointTarget; - // Add two points, which are assumed to be non-equal. + /// Add two points, which are assumed to be non-equal. fn curve_add( &mut self, p1: &AffinePointTarget, @@ -169,7 +169,6 @@ impl, const D: usize> CircuitBuilderCurve result } - // Add two points, which are assumed to be non-equal. fn curve_add( &mut self, p1: &AffinePointTarget,