From 5719c0b70b1485085a04791ac079293ceac56420 Mon Sep 17 00:00:00 2001 From: Daniel Lubarov Date: Tue, 3 Jan 2023 11:23:28 -0800 Subject: [PATCH] feedback --- evm/src/fixed_recursive_verifier.rs | 3 +++ evm/src/recursive_verifier.rs | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/evm/src/fixed_recursive_verifier.rs b/evm/src/fixed_recursive_verifier.rs index 8fa19b3b..1530a071 100644 --- a/evm/src/fixed_recursive_verifier.rs +++ b/evm/src/fixed_recursive_verifier.rs @@ -402,6 +402,9 @@ where } } +/// Our usual recursion threshold is 2^12 gates, but for these shrinking circuits, we use a few more +/// gates for a constant inner VK and for public inputs. This pushes us over the threshold to 2^13. +/// As long as we're at 2^13 gates, we might as well use a narrower witness. fn shrinking_config() -> CircuitConfig { CircuitConfig { num_routed_wires: 40, diff --git a/evm/src/recursive_verifier.rs b/evm/src/recursive_verifier.rs index 59a37602..5ab30a1f 100644 --- a/evm/src/recursive_verifier.rs +++ b/evm/src/recursive_verifier.rs @@ -83,7 +83,6 @@ fn next_chunk(iter: &mut impl Iterator) -> [ impl PublicInputs { pub(crate) fn from_vec(v: &[T], config: &StarkConfig) -> Self { - log::info!("from_vec {}", v.len()); let mut iter = v.iter().copied(); let trace_cap = (0..config.fri_config.num_cap_elements()) .map(|_| next_chunk::<_, 4>(&mut iter).to_vec()) @@ -99,7 +98,6 @@ impl PublicInputs { let challenger_state_before = next_chunk(&mut iter); let challenger_state_after = next_chunk(&mut iter); let ctl_zs_last: Vec<_> = iter.collect(); - log::info!("from_vec num Zs: {}", ctl_zs_last.len()); // TODO Self { trace_cap,