From 56ebda498163cd5c96f2ae7a4e683d7069ec6115 Mon Sep 17 00:00:00 2001 From: Robin Salen Date: Thu, 10 Aug 2023 10:40:47 -0400 Subject: [PATCH] Address review --- evm/src/keccak_sponge/keccak_sponge_stark.rs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/evm/src/keccak_sponge/keccak_sponge_stark.rs b/evm/src/keccak_sponge/keccak_sponge_stark.rs index 6bbe1624..921a234d 100644 --- a/evm/src/keccak_sponge/keccak_sponge_stark.rs +++ b/evm/src/keccak_sponge/keccak_sponge_stark.rs @@ -358,15 +358,13 @@ impl, const D: usize> KeccakSpongeStark { row.updated_state_u32s = sponge_state.map(F::from_canonical_u32); let is_final_block = row.is_final_input_len.iter().copied().sum::() == F::ONE; if is_final_block { - let mut cur_bytes = vec![F::ZERO; 4]; for (l, &elt) in row.updated_state_u32s[..8].iter().enumerate() { let mut cur_elt = elt; - for i in 0..4 { - cur_bytes[i] = + (0..4).for_each(|i| { + row.updated_state_bytes[l * 4 + i] = F::from_canonical_u32((cur_elt.to_canonical_u64() & 0xFF) as u32); cur_elt = F::from_canonical_u64(cur_elt.to_canonical_u64() >> 8); - row.updated_state_bytes[l * 4 + i] = cur_bytes[i]; - } + }); let mut s = row.updated_state_bytes[l * 4].to_canonical_u64(); for i in 1..4 {