From 47b9936487597595b3e501355b6cdc0593afdb9a Mon Sep 17 00:00:00 2001 From: wborgeaud Date: Fri, 23 Jul 2021 08:15:13 +0200 Subject: [PATCH] PR feedback --- src/gadgets/arithmetic.rs | 2 +- src/gadgets/range_check.rs | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/gadgets/arithmetic.rs b/src/gadgets/arithmetic.rs index f27a185f..b858671d 100644 --- a/src/gadgets/arithmetic.rs +++ b/src/gadgets/arithmetic.rs @@ -192,7 +192,7 @@ impl, const D: usize> CircuitBuilder { pub fn exp_from_complement_bits( &mut self, base: Target, - exponent_bits: impl ExactSizeIterator>, + exponent_bits: impl Iterator>, ) -> Target { let mut current = base; let one_ext = self.one_extension(); diff --git a/src/gadgets/range_check.rs b/src/gadgets/range_check.rs index 261e5c7d..e3408cbf 100644 --- a/src/gadgets/range_check.rs +++ b/src/gadgets/range_check.rs @@ -14,11 +14,10 @@ impl, const D: usize> CircuitBuilder { self.route(x, sum); } - /// Returns the first `n_log` little-endian bits of `x`. - /// Note: `x` is assumed to be range-checked for having `num_bits` bits. - pub fn low_bits(&mut self, x: Target, n_log: usize, num_bits: usize) -> Vec { + /// Returns the first `num_low_bits` little-endian bits of `x`. + pub fn low_bits(&mut self, x: Target, num_low_bits: usize, num_bits: usize) -> Vec { let mut res = self.split_le(x, num_bits); - res.truncate(n_log); + res.truncate(num_low_bits); res }