From 39c793a380759c3d9c82b16195d004143f4516f7 Mon Sep 17 00:00:00 2001 From: wborgeaud Date: Tue, 15 Jun 2021 08:35:06 +0200 Subject: [PATCH] Fixes from PR feedback --- src/circuit_data.rs | 2 +- src/witness.rs | 13 +++---------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/src/circuit_data.rs b/src/circuit_data.rs index 466779da..7429e62a 100644 --- a/src/circuit_data.rs +++ b/src/circuit_data.rs @@ -49,7 +49,7 @@ impl CircuitConfig { self.num_wires - self.num_routed_wires } - pub fn large_config() -> Self { + pub(crate) fn large_config() -> Self { Self { num_wires: 134, num_routed_wires: 12, diff --git a/src/witness.rs b/src/witness.rs index c5748c3f..e71b1cfb 100644 --- a/src/witness.rs +++ b/src/witness.rs @@ -89,16 +89,9 @@ impl PartialWitness { F: Extendable, { let limbs = value.to_basefield_array(); - for i in 0..D { - let opt_old_value = self.target_values.insert(et.0[i], limbs[i]); - if let Some(old_value) = opt_old_value { - assert_eq!( - old_value, limbs[i], - "Target was set twice with different values: {:?}", - et.0[i] - ); - } - } + (0..D).for_each(|i| { + self.set_target(et.0[i], limbs[i]); + }); } pub fn set_wire(&mut self, wire: Wire, value: F) {