logos-storage/plonky2
1
0
Fork 0
mirror of https://github.com/logos-storage/plonky2.git synced 2026-05-29 13:19:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

addressed nits

Browse Source
This commit is contained in:
Nicholas Ward 2021-07-01 12:00:56 -07:00
parent efe39f2d63
commit 39b22a6cab
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/gadgets/insert.rs
View File

@ -6,11 +6,14 @@ use crate::target::Target;
impl<F: Extendable<D>, const D: usize> CircuitBuilder<F, D> { impl<F: Extendable<D>, const D: usize> CircuitBuilder<F, D> {
/// Evaluates to 0 if `x` equals zero, 1 otherwise. /// Evaluates to 0 if `x` equals zero, 1 otherwise.
/// From section 2 of https://github.com/mir-protocol/r1cs-workshop/blob/master/workshop.pdf,
/// based on an idea from https://eprint.iacr.org/2012/598.pdf.
pub fn is_nonzero(&mut self, x: Target) -> Target { pub fn is_nonzero(&mut self, x: Target) -> Target {
// Dummy variable. // Dummy variable.
let m = self.add_virtual_target(); let m = self.add_virtual_target();
// The prover sets the dummy variable to 0 if x == 0 and to 1/x otherwise. // The prover sets this the dummy variable to 1/x if x != 0, or to an arbitrary value if
// x == 0.
self.add_generator(NonzeroTestGenerator { self.add_generator(NonzeroTestGenerator {
to_test: x, to_test: x,
dummy: m, dummy: m,

4
src/generator.rs
View File

@ -151,8 +151,6 @@ impl<F: Field> SimpleGenerator<F> for NonzeroTestGenerator {
to_test_value.inverse() to_test_value.inverse()
}; };
let mut witness = PartialWitness::new(); PartialWitness::singleton_target(self.dummy, dummy_value)
witness.set_target(self.dummy, dummy_value);
witness
} }
} }