logos-storage/plonky2
1
0
Fork 0
mirror of https://github.com/logos-storage/plonky2.git synced 2026-01-03 06:13:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #770 from mir-protocol/mpt_insert_3

Browse Source 
Insertion optimization for leaf case
This commit is contained in:
Daniel Lubarov 2022-10-09 21:35:07 -07:00 committed by GitHub
commit 39a7227475
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
evm/src/cpu/kernel/asm/mpt/insert.asm
View File

@ -121,14 +121,25 @@ mpt_insert_leaf:
// stack: node_key, insert_len, insert_key, node_payload_ptr, value_ptr, retdest
DUP4 %mload_trie_data
// stack: node_len, node_key, insert_len, insert_key, node_payload_ptr, value_ptr, retdest
// TODO: Maybe skip %split_common_prefix if lengths & keys exactly match.
// If the keys match, i.e. node_len == insert_len && node_key == insert_key,
// then we're simply replacing the leaf node's value. Since this is a common
// case, it's best to detect it early. Calling %split_common_prefix could be
// expensive as leaf keys tend to be long.
DUP1 DUP4 EQ // node_len == insert_len
DUP3 DUP6 EQ // node_key == insert_key
MUL // Cheaper than AND
// stack: key_match, node_len, node_key, insert_len, insert_key, node_payload_ptr, value_ptr, retdest
%jumpi(mpt_insert_leaf_keys_match)
%split_common_prefix
// stack: common_len, common_key, node_len, node_key, insert_len, insert_key, node_payload_ptr, value_ptr, retdest
DUP3 DUP6 ADD %jumpi(mpt_insert_leaf_not_exact_match)
// If we got here, the node key exactly matches the insert key, so we will
// keep the same leaf node structure and just replace its value.
%stack (common_len, common_key, node_len, node_key, insert_len, insert_key, node_payload_ptr, value_ptr)
-> (common_len, common_key, value_ptr)
PANIC // TODO
mpt_insert_leaf_keys_match:
// The keys match exactly, so we simply create a new leaf node with the new value.xs
// stack: node_len, node_key, insert_len, insert_key, node_payload_ptr, value_ptr, retdest
%stack (node_len, node_key, insert_len, insert_key, node_payload_ptr, value_ptr)
-> (node_len, node_key, value_ptr)
// stack: common_len, common_key, value_ptr, retdest
%get_trie_data_size
// stack: updated_leaf_ptr, common_len, common_key, value_ptr, retdest
@ -136,10 +147,6 @@ mpt_insert_leaf:
SWAP1 %append_to_trie_data // append common_len
SWAP1 %append_to_trie_data // append common_key
SWAP1 %append_to_trie_data // append value_ptr
// stack: updated_leaf_ptr, retdest
// stack: updated_leaf_ptr, retdestx
SWAP1
JUMP
mpt_insert_leaf_not_exact_match:
// stack: common_len, common_key, node_len, node_key, insert_len, insert_key, node_payload_ptr, value_ptr, retdest
// %get_trie_data_size
PANIC // TODO