logos-storage/plonky2
1
0
Fork 0
mirror of https://github.com/logos-storage/plonky2.git synced 2026-01-03 14:23:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent shift ops from panicking (#1073)

Browse Source
This commit is contained in:
Robin Salen 2023-06-06 09:39:36 +02:00 committed by GitHub
parent 55b29cacf8
commit 2cf31f5f2d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
evm/src/witness/operation.rs
View File

@ -468,7 +468,12 @@ pub(crate) fn generate_shl<F: Field>(
) -> Result<(), ProgramError> {
let [(input0, log_in0), (input1, log_in1)] =
stack_pop_with_log_and_fill::<2, _>(state, &mut row)?;
let result = input1 << input0;
let result = if input0 > U256::from(255u64) {
U256::zero()
} else {
input1 << input0
};
append_shift(state, row, input0, log_in0, log_in1, result)
}
@ -478,7 +483,12 @@ pub(crate) fn generate_shr<F: Field>(
) -> Result<(), ProgramError> {
let [(input0, log_in0), (input1, log_in1)] =
stack_pop_with_log_and_fill::<2, _>(state, &mut row)?;
let result = input1 >> input0;
let result = if input0 > U256::from(255u64) {
U256::zero()
} else {
input1 >> input0
};
append_shift(state, row, input0, log_in0, log_in1, result)
}