From 2bfa45447628aa88c70ee6d9fcb9c3f967342c1c Mon Sep 17 00:00:00 2001
From: wborgeaud <williamborgeaud@gmail.com>
Date: Thu, 12 Aug 2021 18:21:21 +0200
Subject: [PATCH] PR feedback

---
 src/plonk/vanishing_poly.rs | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/plonk/vanishing_poly.rs b/src/plonk/vanishing_poly.rs
index 73eaadc7..e2180552 100644
--- a/src/plonk/vanishing_poly.rs
+++ b/src/plonk/vanishing_poly.rs
@@ -240,8 +240,7 @@ pub fn evaluate_gate_constraints_recursively<F: Extendable<D>, const D: usize>(
     num_gate_constraints: usize,
     vars: EvaluationTargets<D>,
 ) -> Vec<ExtensionTarget<D>> {
-    let mut constraints = vec![builder.zero_extension(); num_gate_constraints];
-    let mut all_gate_constraints: Vec<Vec<_>> = Vec::new();
+    let mut all_gate_constraints = vec![vec![]; num_gate_constraints];
     for gate in gates {
         let gate_constraints = with_context!(
             builder,
@@ -251,13 +250,10 @@ pub fn evaluate_gate_constraints_recursively<F: Extendable<D>, const D: usize>(
                 .eval_filtered_recursively(builder, vars, &gate.prefix)
         );
         for (i, c) in gate_constraints.into_iter().enumerate() {
-            if i < all_gate_constraints.len() {
-                all_gate_constraints[i].push(c);
-            } else {
-                all_gate_constraints.push(vec![c]);
-            }
+            all_gate_constraints[i].push(c);
         }
     }
+    let mut constraints = vec![builder.zero_extension(); num_gate_constraints];
     for (i, v) in all_gate_constraints.into_iter().enumerate() {
         constraints[i] = builder.add_many_extension(&v);
     }