From 237a1fad1d02fd65d0e4a079afbd136b90616fa0 Mon Sep 17 00:00:00 2001
From: Nicholas Ward <npward@berkeley.edu>
Date: Mon, 1 Nov 2021 15:22:21 -0700
Subject: [PATCH] addressed comments

---
 src/gadgets/nonnative.rs | 5 ++++-
 src/iop/generator.rs     | 2 ++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/gadgets/nonnative.rs b/src/gadgets/nonnative.rs
index 161a0e85..086e2c83 100644
--- a/src/gadgets/nonnative.rs
+++ b/src/gadgets/nonnative.rs
@@ -155,7 +155,10 @@ mod tests {
     fn test_nonnative_sub() -> Result<()> {
         type FF = Secp256K1Base;
         let x_ff = FF::rand();
-        let y_ff = FF::rand();
+        let mut y_ff = FF::rand();
+        while y_ff.to_biguint() > x_ff.to_biguint() {
+            y_ff = FF::rand();
+        }
         let diff_ff = x_ff - y_ff;
 
         type F = CrandallField;
diff --git a/src/iop/generator.rs b/src/iop/generator.rs
index c5c67bcb..8c6cb294 100644
--- a/src/iop/generator.rs
+++ b/src/iop/generator.rs
@@ -160,6 +160,8 @@ impl<F: Field> GeneratedValues<F> {
 
     pub fn set_biguint_target(&mut self, target: BigUintTarget, value: BigUint) {
         let mut limbs = value.to_u32_digits();
+        assert!(target.num_limbs() >= limbs.len());
+
         limbs.resize(target.num_limbs(), 0);
         for i in 0..target.num_limbs() {
             self.set_u32_target(target.get_limb(i), limbs[i]);