logos-storage/plonky2
1
0
Fork 0
mirror of https://github.com/logos-storage/plonky2.git synced 2026-01-21 15:13:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Pop

Browse Source
This commit is contained in:
Daniel Lubarov 2022-12-01 11:21:40 -08:00
parent 027dfc14b6
commit 231042acb6
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
evm/src/witness/operation.rs
View File

@ -118,7 +118,14 @@ pub(crate) fn generate_pop<F: Field>(
state: &mut GenerationState<F>,
mut row: CpuColumnsView<F>,
) -> Result<(), ProgramError> {
todo!()
if state.registers.stack_len == 0 {
return Err(ProgramError::StackUnderflow);
}
state.registers.stack_len -= 1;
state.traces.push_memory(log_in0);
state.traces.push_cpu(row);
Ok(())
}
pub(crate) fn generate_jump<F: Field>(
@ -193,7 +200,8 @@ pub(crate) fn generate_push<F: Field>(
// In any subsequent cycles, we read up to 1 + NUM_GP_CHANNELS bytes.
for mut addrs_chunk in &addrs.chunks(1 + NUM_GP_CHANNELS) {
let mut row = CpuColumnsView::default();
// TODO: Set other row fields, like push=1?
row.is_cpu_cycle = F::ONE;
row.op.push = F::ONE;
let first_addr = addrs_chunk.next().unwrap();
let (_, first_read) = mem_read_code_with_log_and_fill(first_addr, state, &mut row);