From 1dc22b761f22c2b2c9fa5334e0b87c72dc9154c5 Mon Sep 17 00:00:00 2001 From: Utsav Jain <43694826+utsavjnn@users.noreply.github.com> Date: Thu, 1 Feb 2024 19:19:36 +0530 Subject: [PATCH] Fix BaseSumGenerator and BaseSplitGenerator Ids (#1494) * fix: different ids for generators with different bases required for correct serialisation Signed-off-by: electron-team * fixing wasm32 build issue Signed-off-by: electron-team * fix fmt issue Signed-off-by: electron-team --------- Signed-off-by: electron-team --- plonky2/src/gadgets/split_base.rs | 6 +++--- plonky2/src/gates/base_sum.rs | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/plonky2/src/gadgets/split_base.rs b/plonky2/src/gadgets/split_base.rs index 1562323c..a2c98ac7 100644 --- a/plonky2/src/gadgets/split_base.rs +++ b/plonky2/src/gadgets/split_base.rs @@ -1,6 +1,6 @@ -use alloc::string::{String, ToString}; -use alloc::vec; +use alloc::string::String; use alloc::vec::Vec; +use alloc::{format, vec}; use core::borrow::Borrow; use itertools::Itertools; @@ -91,7 +91,7 @@ impl, const B: usize, const D: usize> SimpleGenerat for BaseSumGenerator { fn id(&self) -> String { - "BaseSumGenerator".to_string() + format!("BaseSumGenerator + Base: {B}") } fn dependencies(&self) -> Vec { diff --git a/plonky2/src/gates/base_sum.rs b/plonky2/src/gates/base_sum.rs index 087f2bf6..1d0f8f80 100644 --- a/plonky2/src/gates/base_sum.rs +++ b/plonky2/src/gates/base_sum.rs @@ -1,4 +1,4 @@ -use alloc::string::{String, ToString}; +use alloc::string::String; use alloc::vec::Vec; use alloc::{format, vec}; use core::ops::Range; @@ -179,7 +179,7 @@ impl, const B: usize, const D: usize> SimpleGenerat for BaseSplitGenerator { fn id(&self) -> String { - "BaseSplitGenerator".to_string() + format!("BaseSplitGenerator + Base: {B}") } fn dependencies(&self) -> Vec {