logos-storage/plonky2
1
0
Fork 0
mirror of https://github.com/logos-storage/plonky2.git synced 2026-01-10 17:53:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

addmul test: use carry

Browse Source
This commit is contained in:
Nicholas Ward 2023-02-15 14:50:41 -08:00
parent efd5e6ec9a
commit 10893fe056
2 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
evm/src/cpu/kernel/asm/bignum/addmul.asm
View File

@ -1,7 +1,7 @@
// Arithmetic on little-endian integers represented with 128-bit limbs.
// All integers must be under a given length bound, and are padded with leading zeroes.
// Sets a[0:len] += b[0:len] * val.
// Sets a[0:len+1] += b[0:len] * val.
global addmul_bignum:
// stack: len, a_start_loc, b_start_loc, val, retdest
PUSH 0

18
evm/src/cpu/kernel/tests/bignum.rs
View File

@ -3,6 +3,7 @@ use ethereum_types::U256;
use itertools::Itertools;
use num::BigUint;
use num_bigint::RandBigInt;
use rand::Rng;
use crate::cpu::kernel::aggregator::KERNEL;
use crate::cpu::kernel::interpreter::Interpreter;
@ -151,7 +152,7 @@ fn test_add_bignum() -> Result<()> {
let expected_sum: Vec<U256> = biguint_to_mem_vec(sum);
let a_start_loc = 0.into();
let b_start_loc = length;
let b_start_loc = length ;
// Prepare stack.
let retdest = 0xDEADBEEFu32.into();
@ -178,9 +179,12 @@ fn test_add_bignum() -> Result<()> {
#[test]
fn test_addmul_bignum() -> Result<()> {
let _rng = rand::thread_rng();
let (a, b, length, memory) = prepare_two_bignums(1000);
let val: u64 = 1;
let mut rng = rand::thread_rng();
let (a, b, length, mut memory) = prepare_two_bignums(1000);
let len: usize = length.try_into().unwrap();
memory.splice(len..len, vec![0.into(); 2].iter().cloned());
let val: u64 = rng.gen();
let val_u256 = U256::from(val);
// Determine expected result.
@ -188,7 +192,7 @@ fn test_addmul_bignum() -> Result<()> {
let expected_result: Vec<U256> = biguint_to_mem_vec(result);
let a_start_loc = 0.into();
let b_start_loc = length;
let b_start_loc = length + 2;
// Prepare stack.
let retdest = 0xDEADBEEFu32.into();
@ -204,7 +208,9 @@ fn test_addmul_bignum() -> Result<()> {
interpreter.run()?;
// Determine actual result.
let new_memory = interpreter.get_kernel_general_memory();
let carry = interpreter.stack()[0];
let mut new_memory = interpreter.get_kernel_general_memory();
new_memory[len] = carry;
let actual_result: Vec<_> = new_memory[..expected_result.len()].into();
dbg!(interpreter.stack());