From 04fbb05d7c04ec0a9f8da19dde8fa03c4dd520df Mon Sep 17 00:00:00 2001 From: Jakub Nabaglo Date: Fri, 21 Jan 2022 15:55:24 -0800 Subject: [PATCH] Swap loops in `compute_quotient_polys` (#444) --- plonky2/src/plonk/prover.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/plonky2/src/plonk/prover.rs b/plonky2/src/plonk/prover.rs index 0dd2aba2..2a11e4c0 100644 --- a/plonky2/src/plonk/prover.rs +++ b/plonky2/src/plonk/prover.rs @@ -403,17 +403,17 @@ fn compute_quotient_polys< // NB (JN): I'm not sure how (in)efficient the below is. It needs measuring. let mut local_constants_batch = vec![F::ZERO; xs_batch.len() * local_constants_batch_refs[0].len()]; - for (i, constants) in local_constants_batch_refs.iter().enumerate() { - for (j, &constant) in constants.iter().enumerate() { - local_constants_batch[i + j * xs_batch.len()] = constant; + for i in 0..local_constants_batch_refs[0].len() { + for (j, constants) in local_constants_batch_refs.iter().enumerate() { + local_constants_batch[i * xs_batch.len() + j] = constants[i]; } } let mut local_wires_batch = vec![F::ZERO; xs_batch.len() * local_wires_batch_refs[0].len()]; - for (i, wires) in local_wires_batch_refs.iter().enumerate() { - for (j, &wire) in wires.iter().enumerate() { - local_wires_batch[i + j * xs_batch.len()] = wire; + for i in 0..local_wires_batch_refs[0].len() { + for (j, wires) in local_wires_batch_refs.iter().enumerate() { + local_wires_batch[i * xs_batch.len() + j] = wires[i]; } }