From 492fb0d3c2597e66282c6576b6837e36e59c550c Mon Sep 17 00:00:00 2001 From: Arnaud Date: Thu, 16 Apr 2026 09:58:31 +0400 Subject: [PATCH] Remove logs with generics --- serde.nimble | 2 +- serde/json/serializer.nim | 15 ++------------- 2 files changed, 3 insertions(+), 14 deletions(-) diff --git a/serde.nimble b/serde.nimble index c7e7912..f8100be 100644 --- a/serde.nimble +++ b/serde.nimble @@ -7,7 +7,7 @@ license = "MIT" skipDirs = @["tests"] # Dependencies -requires "chronicles >= 0.10.3" +requires "chronicles >= 0.12.3" requires "questionable >= 0.10.13 & < 0.11.0" requires "stint" requires "stew" diff --git a/serde/json/serializer.nim b/serde/json/serializer.nim index 00fdfa2..bad06f3 100644 --- a/serde/json/serializer.nim +++ b/serde/json/serializer.nim @@ -13,7 +13,6 @@ import ./stdjson import ./pragmas import ./types -export chronicles except toJson export stdjson export pragmas export types @@ -91,35 +90,25 @@ proc `%`*[T: object or ref object](obj: T): JsonNode = let mode = T.getSerdeMode(serialize) for name, value in o.fieldPairs: - logScope: - field = $T & "." & name - mode - let opts = getSerdeFieldOptions(serialize, name, value) let hasSerialize = value.hasCustomPragma(serialize) var skip = false # workaround for 'continue' not supported in a 'fields' loop - # logScope moved into proc due to chronicles issue: https://github.com/status-im/nim-chronicles/issues/148 - logScope: - topics = "serde json serialization" - case mode of OptIn: if not hasSerialize: - trace "object field not marked with serialize, skipping" skip = true elif opts.ignore: skip = true of OptOut: if opts.ignore: - trace "object field opted out of serialization ('ignore' is set), skipping" skip = true elif hasSerialize and opts.key == name: # all serialize params are default - warn "object field marked as serialize in OptOut mode, but 'ignore' not set, field will be serialized" + discard of Strict: if opts.ignore: # unable to figure out a way to make this a compile time check - warn "object field marked as 'ignore' while in Strict mode, field will be serialized anyway" + discard if not skip: jsonObj[opts.key] = %value