From 388be95f686e0d3d1ab0076cb98f846ae3f6fbfe Mon Sep 17 00:00:00 2001 From: Ben Date: Fri, 26 Apr 2024 10:20:09 +0200 Subject: [PATCH] Adds comments to chronicles issue --- serde/json/deserializer.nim | 1 + serde/json/serializer.nim | 1 + 2 files changed, 2 insertions(+) diff --git a/serde/json/deserializer.nim b/serde/json/deserializer.nim index be2961b..d555be2 100644 --- a/serde/json/deserializer.nim +++ b/serde/json/deserializer.nim @@ -185,6 +185,7 @@ proc fromJson*[T: ref object or object](_: type T, json: JsonNode): ?!T = let isOptionalValue = typeof(value) is Option var skip = false # workaround for 'continue' not supported in a 'fields' loop + # logScope moved into proc due to chronicles issue: https://github.com/status-im/nim-chronicles/issues/148 logScope: topics = "serde json deserialization" diff --git a/serde/json/serializer.nim b/serde/json/serializer.nim index fe6deb5..ddd8a4c 100644 --- a/serde/json/serializer.nim +++ b/serde/json/serializer.nim @@ -96,6 +96,7 @@ proc `%`*[T: object or ref object](obj: T): JsonNode = let hasSerialize = value.hasCustomPragma(serialize) var skip = false # workaround for 'continue' not supported in a 'fields' loop + # logScope moved into proc due to chronicles issue: https://github.com/status-im/nim-chronicles/issues/148 logScope: topics = "serde json serialization"