logos-storage/nim-nitro
1
0
Fork 0
mirror of https://github.com/logos-storage/nim-nitro.git synced 2026-01-05 23:23:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Payment is not accepted when there are unexpected changes in state

Browse Source
This commit is contained in:
Mark Spanbroek 2021-03-22 15:23:31 +01:00
parent f5022a6ee1
commit 85ff1d3835
2 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
nitro/wallet/wallet.nim
View File

@ -171,5 +171,13 @@ func acceptPayment*(wallet: var Wallet,
if not payment.isSignedBy(sender): if not payment.isSignedBy(sender):
return void.failure "missing signature on payment" return void.failure "missing signature on payment"
if updatedBalances =? payment.state.outcome.balances(asset):
var expectedState: State = wallet.channels?[channel]?.state.get
expectedState.outcome.update(asset, updatedBalances)
if payment.state != expectedState:
return void.failure "payment has unexpected changes in state"
else:
return void.failure "payment misses balances for asset"
wallet.channels[channel] = payment wallet.channels[channel] = payment
ok() ok()

18
tests/nitro/testWallet.nim
View File

@ -164,7 +164,7 @@ suite "wallet: accepting payments":
check receiver.acceptPayment(channel, asset, payer.address, payment).isOk check receiver.acceptPayment(channel, asset, payer.address, payment).isOk
check receiver.balance(channel, asset, receiver.address) == 42.u256 check receiver.balance(channel, asset, receiver.address) == 42.u256
test "does not accept a decrease in receiver balance": test "fails when receiver balance is decreased":
let payment1 = payer.pay(channel, asset, receiver.address, 10.u256).get let payment1 = payer.pay(channel, asset, receiver.address, 10.u256).get
let payment2 = payer.pay(channel, asset, receiver.address, 10.u256).get let payment2 = payer.pay(channel, asset, receiver.address, 10.u256).get
check receiver.acceptPayment(channel, asset, payer.address, payment1).isOk check receiver.acceptPayment(channel, asset, payer.address, payment1).isOk
@ -172,31 +172,37 @@ suite "wallet: accepting payments":
check receiver.acceptPayment(channel, asset, payer.address, payment1).isErr check receiver.acceptPayment(channel, asset, payer.address, payment1).isErr
check receiver.balance(channel, asset, receiver.address) == 20 check receiver.balance(channel, asset, receiver.address) == 20
test "does not accept a payment where the total supply of the asset changes": test "fails when the total supply of the asset changes":
var payment = payer.pay(channel, asset, receiver.address, 10.u256).get var payment = payer.pay(channel, asset, receiver.address, 10.u256).get
var balances = payment.state.outcome.balances(asset).get var balances = payment.state.outcome.balances(asset).get
balances[payer.destination] += 10.u256 balances[payer.destination] += 10.u256
payment.state.outcome.update(asset, balances) payment.state.outcome.update(asset, balances)
check receiver.acceptPayment(channel, asset, payer.address, payment).isErr check receiver.acceptPayment(channel, asset, payer.address, payment).isErr
test "does not accept a payment without a signature": test "fails without a signature":
var payment = payer.pay(channel, asset, receiver.address, 10.u256).get var payment = payer.pay(channel, asset, receiver.address, 10.u256).get
payment.signatures = @[] payment.signatures = @[]
check receiver.acceptPayment(channel, asset, payer.address, payment).isErr check receiver.acceptPayment(channel, asset, payer.address, payment).isErr
test "does not accept a payment with an incorrect signature": test "fails with an incorrect signature":
var payment = payer.pay(channel, asset, receiver.address, 10.u256).get var payment = payer.pay(channel, asset, receiver.address, 10.u256).get
payment.signatures = @[Signature.example] payment.signatures = @[Signature.example]
check receiver.acceptPayment(channel, asset, payer.address, payment).isErr check receiver.acceptPayment(channel, asset, payer.address, payment).isErr
test "does not accept a payment for an unknown channel": test "fails when channel is unknown":
let newChannel = payer.openLedgerChannel( let newChannel = payer.openLedgerChannel(
receiver.address, chainId, nonce + 1, asset, 100.u256).get receiver.address, chainId, nonce + 1, asset, 100.u256).get
let payment = payer.pay(newChannel, asset, receiver.address, 10.u256).get let payment = payer.pay(newChannel, asset, receiver.address, 10.u256).get
check receiver.acceptPayment(newChannel, asset, payer.address, payment).isErr check receiver.acceptPayment(newChannel, asset, payer.address, payment).isErr
test "does not accept a payment for a different channel": test "fails when payment does not match channel":
let newChannel = payer.openLedgerChannel( let newChannel = payer.openLedgerChannel(
receiver.address, chainId, nonce + 1, asset, 100.u256).get receiver.address, chainId, nonce + 1, asset, 100.u256).get
let payment = payer.pay(newChannel, asset, receiver.address, 10.u256).get let payment = payer.pay(newChannel, asset, receiver.address, 10.u256).get
check receiver.acceptPayment(channel, asset, payer.address, payment).isErr check receiver.acceptPayment(channel, asset, payer.address, payment).isErr
test "fails when state is updated in unrelated areas":
var payment = payer.pay(channel, asset, receiver.address, 10.u256).get
payment.state.appDefinition = EthAddress.example
payment.signatures = @[payerKey.sign(payment.state)]
check receiver.acceptPayment(channel, asset, payer.address, payment).isErr