diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index af0c87a..58e4eaa 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -94,10 +94,6 @@ jobs: runs-on: ubuntu-latest needs: build steps: - - name: Docker - Variables - run: | - # Set tags - echo "TAGS=${{ env.DOCKER_REPO }}:${{ env.NIM_VERSION }}" >> $GITHUB_ENV - name: Docker - Download digests uses: actions/download-artifact@v4 @@ -114,7 +110,7 @@ jobs: uses: docker/metadata-action@v5 with: images: ${{ env.DOCKERHUB_REPO }} - tags: ${{ env.TAGS }} + tags: ${{ env.NIM_VERSION }} - name: Docker - Login to Docker Hub uses: docker/login-action@v3 diff --git a/README.md b/README.md index 3fabe79..353253f 100644 --- a/README.md +++ b/README.md @@ -13,7 +13,20 @@ Code in the repository provides a simple way to build multi-arch Docker images with a required Nim version. However, builds are triggered manually. - We are using GitHub Actions and rely on [nimv](https://github.com/emizzle/nimv) for Nim installation. + For builds we are using GitHub Actions and rely on [nimv](https://github.com/emizzle/nimv) for Nim installation. + +**Considerations** + - We are using only `amd64` and `arm64` architecture + - We are using [ubuntu](https://hub.docker.com/_/ubuntu) for our apps container and use it for nim-lang as well + - Multi-platform builds using [QEMU](https://github.com/docker/setup-qemu-action) are very slow `1h56m` vs `12m` + + +## Docker images + + Images are pushed and available on [DockerHub](https://hub.docker.com/r/codexstorage/nim-lang/tags) + ```shell + docker run --rm codexstorage/nim-lang:2.0.14 nim --version + ``` ## Build your own images